public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	Guenter Roeck <linux@roeck-us.net>,
	Andy Lutomirski <luto@amacapital.net>,
	David Daney <david.daney@cavium.com>
Subject: [PATCH] mips: Fix build if PERF_EVENTS is configured
Date: Wed,  8 Apr 2015 13:29:52 -0700	[thread overview]
Message-ID: <1428524992-5979-1-git-send-email-linux@roeck-us.net> (raw)

mips builds fail in -next as follows if PERF_EVENTS is configured.

kernel/built-in.o: In function `perf_sample_regs_user':
kernel/events/core.c:4828: undefined reference to `perf_get_regs_user'

The problem is caused by commit 3478e32c1545 ("MIPS: Add user stack and
registers to perf.") in combination with commit 88a7c26af8da ("perf:
Move task_pt_regs sampling into arch code"), which introduces
perf_get_regs_user().

Cc: Andy Lutomirski <luto@amacapital.net>
Cc: David Daney <david.daney@cavium.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Compile tested only.

 arch/mips/kernel/perf_regs.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/mips/kernel/perf_regs.c b/arch/mips/kernel/perf_regs.c
index 0451c4b..5b04454 100644
--- a/arch/mips/kernel/perf_regs.c
+++ b/arch/mips/kernel/perf_regs.c
@@ -58,3 +58,11 @@ u64 perf_reg_value(struct pt_regs *regs, int idx)
 
 	return (s64)v; /* Sign extend if 32-bit. */
 }
+
+void perf_get_regs_user(struct perf_regs *regs_user,
+			struct pt_regs *regs,
+			struct pt_regs *regs_user_copy)
+{
+	regs_user->regs = task_pt_regs(current);
+	regs_user->abi = perf_reg_abi(current);
+}
-- 
2.1.0


             reply	other threads:[~2015-04-08 20:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 20:29 Guenter Roeck [this message]
2015-04-09  0:09 ` [PATCH] mips: Fix build if PERF_EVENTS is configured Ralf Baechle
2015-04-09  3:40   ` Guenter Roeck
2015-04-10 14:05     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428524992-5979-1-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=david.daney@cavium.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=luto@amacapital.net \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox