From: Joe Perches <joe@perches.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Add a test for const with __read_mostly uses
Date: Wed, 08 Apr 2015 17:33:39 -0700 [thread overview]
Message-ID: <1428539619.22406.68.camel@perches.com> (raw)
In-Reply-To: <20150409002851.GV2366@two.firstfloor.org>
On Thu, 2015-04-09 at 02:28 +0200, Andi Kleen wrote:
> On Wed, Apr 08, 2015 at 05:14:49PM -0700, Joe Perches wrote:
> > const objects shouldn't be __read_mostly. They are read-only.
> >
> > Marking these objects as __read_mostly causes section conflicts
> > with LTO linking.
> >
> > So add a test to try to avoid this issue.
>
> I suspect excluding *
> will miss quite a few cases, but there's no way around it.
That excludes only "const <foo> *" not "const foo * const"
so I believe it shouldn't exclude anything that's not
pointer to const.
next prev parent reply other threads:[~2015-04-09 0:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 13:06 [PATCH 1/2] Don't let LATENCYTOP and LOCKDEP select KALLSYMS_ALL Andi Kleen
2015-04-08 13:06 ` [PATCH 2/2] test-hexdump.c: Fix initconst confusion Andi Kleen
2015-04-08 22:35 ` Andrew Morton
2015-04-08 23:52 ` Andi Kleen
2015-04-09 0:14 ` [PATCH] checkpatch: Add a test for const with __read_mostly uses Joe Perches
2015-04-09 0:28 ` Andi Kleen
2015-04-09 0:33 ` Joe Perches [this message]
2015-04-16 19:33 ` [PATCH 2/2] test-hexdump.c: Fix initconst confusion Geert Uytterhoeven
2015-04-16 21:21 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428539619.22406.68.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox