From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932318AbbDJBKw (ORCPT ); Thu, 9 Apr 2015 21:10:52 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33707 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932258AbbDJBKs (ORCPT ); Thu, 9 Apr 2015 21:10:48 -0400 From: Mitchel Humpherys To: devel@linuxdriverproject.org, Greg Kroah-Hartman , Android Kernel Team , Colin Cross , John Stultz Cc: linux-kernel@vger.kernel.org, Mitchel Humpherys Subject: [PATCH v2 2/2] staging: ion: chunk_heap: use %pad for printing dma_addr_t's Date: Thu, 9 Apr 2015 18:10:04 -0700 Message-Id: <1428628204-25752-2-git-send-email-mitchelh@codeaurora.org> X-Mailer: git-send-email 2.3.5 In-Reply-To: <1428628204-25752-1-git-send-email-mitchelh@codeaurora.org> References: <1428628204-25752-1-git-send-email-mitchelh@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We're currently using %lu and %ld to print some variables of type dma_addr_t, which results in the following warning when dma_addr_t is 64-bits wide: drivers/staging/android/ion/ion_chunk_heap.c: In function 'ion_chunk_heap_create': drivers/staging/android/ion/ion_chunk_heap.c:176:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'dma_addr_t' [-Wformat=] pr_info("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base, ^ drivers/staging/android/ion/ion_chunk_heap.c:176:2: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'dma_addr_t' [-Wformat=] Fix this by using %pad as instructed in printk-formats.txt. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/ion_chunk_heap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c index 54746157d799..6b3e18aa1c64 100644 --- a/drivers/staging/android/ion/ion_chunk_heap.c +++ b/drivers/staging/android/ion/ion_chunk_heap.c @@ -173,8 +173,8 @@ struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data) chunk_heap->heap.ops = &chunk_heap_ops; chunk_heap->heap.type = ION_HEAP_TYPE_CHUNK; chunk_heap->heap.flags = ION_HEAP_FLAG_DEFER_FREE; - pr_debug("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base, - heap_data->size, heap_data->align); + pr_debug("%s: base %pad size %zu align %pad\n", __func__, + &chunk_heap->base, heap_data->size, &heap_data->align); return &chunk_heap->heap; -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project