Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

Mark Rutland
2015-04-14T13:57:01Z

> > > smi_common:smi@14022000 {
> > > compatible = “mediate, mt8173-smi”;
> > > reg = <0 0x14022000 0 0x1000>;
> > > clocks = <&mmsys MM_SMI_COMMON>;
> > > clocks-names = “smi_common”;
> > > };
> > >
> > > larb0: larb@14021000 {
> > > compatible = “mediate, mt8173-smi-larb”;
> > > reg = <0 0x14021000 0 0x1000>;
> > > smi = <&smi_common>;
> > > clocks = <&mmsys MM_SMI_LARB0>,
> > > <&mmsys MM_SMI_LARB0>;
> > > clocks-names = “apb_clk”, “smi_clk”;
> > > };
> > >
> > > larb1: larb@16010000 {
> > > compatible = “mediate, mt8173-smi-larb”;
> > > reg = <0 0x16010000 0 0x1000>;
> > > smi = <&smi_common>;
> > > clocks = <&vdecsys VDEC_CKEN>,
> > > <&mmsys VDEC_LARB_CKEN>;
> > > clocks-names = “apb_clk”, “smi_clk”;
> > > };
> > > …
> > > In some local arbiter, the source clock of the APB clock and the
> > > SMI clock may be the same, like larb0. so the two clocks are the same.
> > > And they may be different in other local arbiteres, like larb1.
> > >
> > > If it is designed like this, is it ok?
> >
> > That looks pretty good; the clocks and names on the larb nodes seem
> > sensible.
> >
> > The naming of the "smi_common" clock on the smi_common node looks a bit
> > odd though. Is that really what the clock input is called?
> >
> > Mark.
> After check with DE, the smi_common clock also have its APB clock
> and the smi clock(they have the same clock source).
> And I prepare to delete "_clk" in all the clock-names.
> So it may be like this:
> smi_common:smi@14022000 {
> compatible = “mediate, mt8173-smi”;
> reg = <0 0x14022000 0 0x1000>;
> clocks = <&mmsys MM_SMI_COMMON>,
> <&mmsys MM_SMI_COMMON>;
> clocks-names = “apk”,"smi";
> };
> How about this?

That looks fine to me. I assume "apk" should be "apb" in the last
example.

Mark.