Re: [PATCH 1/5] soc: mediatek: Add SMI driver

Arnd Bergmann
2015-03-09T21:55:45Z

On Monday 09 March 2015 18:59:37 Paul Bolle wrote:
> Hi Yong,
>
> Yong Wu schreef op ma 09-03-2015 om 19:57 [+0800]:
> > On Fri, 2015-03-06 at 12:30 +0100, Paul Bolle wrote:
> > > On Fri, 2015-03-06 at 18:48 +0800, yong.wu@mediatek.com wrote:
> > > > --- a/drivers/soc/mediatek/Kconfig
> > > > +++ b/drivers/soc/mediatek/Kconfig
> > > > @@ -20,3 +20,10 @@ config MT8173_PMIC_WRAP
> > > > PMIC wrapper is a proprietary hardware in MT8173 to make
> > > > communication protocols to access PMIC device.
> > > > This driver implement access protocols for MT8173.
> > > > +
> > > > +config MTK_SMI
> > > > + bool
> > >
> > > Nit: make this one tab instead of 8 spaces, please.
> > >
> > > > + help
> > > > + Smi help enable/disable iommu in mt8173 and control the
> > > > + clock of each local arbiter.
> > > > + It should be true while MTK_IOMMU enable.
> > >
> > > I don't think anyone using the *config tools will ever see this text, as
> > > there's no prompt. So you might as well make this a comment or drop it
> > > altogether.
> > >
> > We could search it in the tool even though we don't see it. In next
> > version, I will try to make it a comment.

No, please leave it the way it was. I prefer having help texts even
for silent options over using comments to do the same.

Arnd