Re: [PATCH 1/5] soc: mediatek: Add SMI driver

Arnd Bergmann
2015-03-09T21:57:31Z

On Monday 09 March 2015 11:26:52 Yingjoe Chen wrote:
> On Fri, 2015-03-06 at 18:48 +0800, yong.wu@mediatek.com wrote:
> > From: Yong Wu <yong.wu@mediatek.com>
> >
> > This patch add SMI(Smart Multimedia Interface) driver. This driver is
> > responsible to enable/disable iommu and control the clocks of each
> > local arbiter.
> >
> > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> > ---
> > drivers/soc/mediatek/Kconfig | 7 ++
> > drivers/soc/mediatek/Makefile | 1 +
> > drivers/soc/mediatek/mt8173-smi.c | 143 ++++++++++++++++++++++++++++++++++++++
> > include/linux/mtk-smi.h | 40 +++++++++++
> > 4 files changed, 191 insertions(+)
> > create mode 100644 drivers/soc/mediatek/mt8173-smi.c
> > create mode 100644 include/linux/mtk-smi.h
> >
>
> Hi Arnd, Matthias,
>
> For the SMI driver, we can't find a better place, so we put it in
> drivers/soc/mediatek now. Please let us know if you have any suggestion
> or concern. Thanks

>From what I understand from your description, I think it would better
fit in drivers/iommu. Another option is drivers/memory, which I think
is where the respective Tegra driver ended up.

Arnd