From: Tyler Baker <tyler.baker@linaro.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Kevin Hilman <khilman@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Darren Hart <dvhart@infradead.org>,
David Herrmann <dh.herrmann@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tyler Baker <tyler.baker@linaro.org>
Subject: [PATCH 5/7] selftests/x86: fix cross build logic
Date: Tue, 14 Apr 2015 15:52:58 -0700 [thread overview]
Message-ID: <1429051978-14778-1-git-send-email-tyler.baker@linaro.org> (raw)
x86 tests should not be built when ARCH != x86. Reused the logic from
breakpoints to determine when it's appropriate to build.
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
tools/testing/selftests/x86/Makefile | 35 +++++++++++++++++++++++------------
1 file changed, 23 insertions(+), 12 deletions(-)
diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index f0a7918..7be67a0 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -7,31 +7,36 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
-UNAME_P := $(shell uname -p)
-
-# Always build 32-bit tests
+# Taken from perf makefile
+uname_M := $(shell uname -m 2>/dev/null || echo not)
+ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
+ifeq ($(ARCH),i386)
+ARCH := x86
all: all_32
-
+endif
+ifeq ($(ARCH),x86_64)
+ARCH := x86
# If we're on a 64-bit host, build 64-bit tests as well
-ifeq ($(shell uname -p),x86_64)
-all: all_64
+all: all_32 all_64
endif
all_32: check_build32 $(BINARIES_32)
all_64: $(BINARIES_64)
-clean:
- $(RM) $(BINARIES_32) $(BINARIES_64)
-
-run_tests:
- ./run_x86_tests.sh
-
$(TARGETS_C_BOTHBITS:%=%_32): %_32: %.c
+ifeq ($(ARCH),x86)
$(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
+else
+ echo "Not an x86 target, can't build x86 tests"
+endif
$(TARGETS_C_BOTHBITS:%=%_64): %_64: %.c
+ifeq ($(ARCH),x86)
$(CC) -m64 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
+else
+ echo "Not an x86 target, can't build x86 tests"
+endif
check_build32:
@if ! $(CC) -m32 -o /dev/null trivial_32bit_program.c; then \
@@ -46,3 +51,9 @@ check_build32:
echo " yum install glibc-devel.*i686"; \
exit 1; \
fi
+
+run_tests:
+ ./run_x86_tests.sh
+
+clean:
+ $(RM) $(BINARIES_32) $(BINARIES_64)
--
2.1.0
next reply other threads:[~2015-04-14 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 22:52 Tyler Baker [this message]
2015-04-15 0:33 ` [PATCH 5/7] selftests/x86: fix cross build logic Andy Lutomirski
2015-04-15 2:54 ` Tyler Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429051978-14778-1-git-send-email-tyler.baker@linaro.org \
--to=tyler.baker@linaro.org \
--cc=dh.herrmann@gmail.com \
--cc=dvhart@infradead.org \
--cc=john.stultz@linaro.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox