From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: lee.jones@linaro.org
Cc: broonie@kernel.org, sameo@linux.intel.com,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
patches@opensource.wolfsonmicro.com
Subject: [PATCH v2 2/9] mfd: arizona: Factor out hard reset into helper functions
Date: Fri, 17 Apr 2015 09:42:19 +0100 [thread overview]
Message-ID: <1429260146-16694-3-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1429260146-16694-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
This patch adds functions for enabling and disabling the physical reset
line. This will be helpful in future refactoring.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-core.c | 25 +++++++++++++++++--------
1 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index be8b1a4..c0e8a96 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -250,6 +250,20 @@ static int arizona_wait_for_boot(struct arizona *arizona)
return ret;
}
+static inline void arizona_enable_reset(struct arizona *arizona)
+{
+ if (arizona->pdata.reset)
+ gpio_set_value_cansleep(arizona->pdata.reset, 0);
+}
+
+static void arizona_disable_reset(struct arizona *arizona)
+{
+ if (arizona->pdata.reset) {
+ gpio_set_value_cansleep(arizona->pdata.reset, 1);
+ msleep(1);
+ }
+}
+
static int arizona_apply_hardware_patch(struct arizona* arizona)
{
unsigned int fll, sysclk;
@@ -751,10 +765,7 @@ int arizona_dev_init(struct arizona *arizona)
goto err_enable;
}
- if (arizona->pdata.reset) {
- gpio_set_value_cansleep(arizona->pdata.reset, 1);
- msleep(1);
- }
+ arizona_disable_reset(arizona);
regcache_cache_only(arizona->regmap, false);
@@ -1054,8 +1065,7 @@ int arizona_dev_init(struct arizona *arizona)
err_irq:
arizona_irq_exit(arizona);
err_reset:
- if (arizona->pdata.reset)
- gpio_set_value_cansleep(arizona->pdata.reset, 0);
+ arizona_enable_reset(arizona);
regulator_disable(arizona->dcvdd);
err_enable:
regulator_bulk_disable(arizona->num_core_supplies,
@@ -1080,8 +1090,7 @@ int arizona_dev_exit(struct arizona *arizona)
arizona_free_irq(arizona, ARIZONA_IRQ_OVERCLOCKED, arizona);
arizona_free_irq(arizona, ARIZONA_IRQ_CLKGEN_ERR, arizona);
arizona_irq_exit(arizona);
- if (arizona->pdata.reset)
- gpio_set_value_cansleep(arizona->pdata.reset, 0);
+ arizona_enable_reset(arizona);
regulator_bulk_disable(arizona->num_core_supplies,
arizona->core_supplies);
--
1.7.2.5
next prev parent reply other threads:[~2015-04-17 8:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 8:42 [PATCH v2 0/9] wm5110 Boot Fixups Charles Keepax
2015-04-17 8:42 ` [PATCH v2 1/9] mfd: arizona: Use devres to manage reset GPIO Charles Keepax
2015-04-29 12:27 ` Lee Jones
2015-04-17 8:42 ` Charles Keepax [this message]
2015-04-29 12:26 ` [PATCH v2 2/9] mfd: arizona: Factor out hard reset into helper functions Lee Jones
2015-04-17 8:42 ` [PATCH v2 3/9] mfd: wm5102: Ensure we always boot the device fully Charles Keepax
2015-04-29 12:25 ` Lee Jones
2015-04-17 8:42 ` [PATCH v2 4/9] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch Charles Keepax
2015-04-29 12:17 ` Lee Jones
2015-04-17 8:42 ` [PATCH v2 5/9] mfd: wm5110: Add register patch required for low power sleep Charles Keepax
2015-04-17 8:42 ` [PATCH v2 6/9] regulator: arizona-ldo1: Add additional supported voltage Charles Keepax
2015-04-17 8:42 ` [PATCH v2 7/9] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode Charles Keepax
2015-04-17 8:42 ` [PATCH v2 8/9] mfd: arizona: Add better support for system suspend Charles Keepax
2015-04-29 12:11 ` Lee Jones
2015-04-17 8:42 ` [PATCH v2 9/9] mfd: wm5110: Add delay before releasing reset line Charles Keepax
2015-04-29 11:54 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429260146-16694-3-git-send-email-ckeepax@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox