From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754210AbbDTG1F (ORCPT ); Mon, 20 Apr 2015 02:27:05 -0400 Received: from p3plsmtps2ded02.prod.phx3.secureserver.net ([208.109.80.59]:48879 "EHLO p3plsmtps2ded02.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754072AbbDTG0h (ORCPT ); Mon, 20 Apr 2015 02:26:37 -0400 x-originating-ip: 72.167.245.219 From: "K. Y. Srinivasan" To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com Cc: "K. Y. Srinivasan" Subject: [PATCH 2/5] Drivers: hv: vmbus: unregister panic notifier on module unload Date: Mon, 20 Apr 2015 00:45:02 -0700 Message-Id: <1429515905-13749-2-git-send-email-kys@microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1429515905-13749-1-git-send-email-kys@microsoft.com> References: <1429515878-13710-1-git-send-email-kys@microsoft.com> <1429515905-13749-1-git-send-email-kys@microsoft.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vitaly Kuznetsov Commit 96c1d0581d00f7abe033350edb021a9d947d8d81 ("Drivers: hv: vmbus: Add support for VMBus panic notifier handler") introduced atomic_notifier_chain_register() call on module load. We also need to call atomic_notifier_chain_unregister() on module unload as otherwise the following crash is observed when we bring hv_vmbus back: [ 39.788877] BUG: unable to handle kernel paging request at ffffffffa00078a8 [ 39.788877] IP: [] notifier_call_chain+0x3f/0x80 ... [ 39.788877] Call Trace: [ 39.788877] [] __atomic_notifier_call_chain+0x5d/0x90 ... [ 39.788877] [] ? atomic_notifier_chain_register+0x38/0x70 [ 39.788877] [] ? atomic_notifier_chain_register+0x17/0x70 [ 39.788877] [] hv_acpi_init+0x14f/0x1000 [hv_vmbus] [ 39.788877] [] do_one_initcall+0xd4/0x210 Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/vmbus_drv.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 0d8d1d7..7870a90 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -1108,6 +1108,10 @@ static void __exit vmbus_exit(void) hv_synic_clockevents_cleanup(); hv_remove_vmbus_irq(); vmbus_free_channels(); + if (ms_hyperv.features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) { + atomic_notifier_chain_unregister(&panic_notifier_list, + &hyperv_panic_block); + } bus_unregister(&hv_bus); hv_cleanup(); for_each_online_cpu(cpu) -- 1.7.4.1