From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754757AbbDTJ07 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Apr 2015 05:26:59 -0400
Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:52232 "EHLO
	lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754247AbbDTJ04 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Apr 2015 05:26:56 -0400
Message-ID: <1429522004.14597.8.camel@x220>
Subject: Re: [PATCH v13 2/3] power-domain: rockchip: add power domain driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Caesar Wang <wxt@rock-chips.com>
Cc: heiko@sntech.de, khilman@linaro.org, linux-arm-kernel@lists.infradead.org,
        tomasz.figa@gmail.com, mark.rutland@arm.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-rockchip@lists.infradead.org,
        dianders@chromium.org, ulf.hansson@linaro.org,
        dmitry.torokhov@gmail.com, broonie@kernel.org, grant.likely@linaro.org,
        "jinkun.hong" <jinkun.hong@rock-chips.com>
Date: Mon, 20 Apr 2015 11:26:44 +0200
In-Reply-To: <1429440280-18915-1-git-send-email-wxt@rock-chips.com>
References: <1429438552-17733-1-git-send-email-wxt@rock-chips.com>
	 <1429440280-18915-1-git-send-email-wxt@rock-chips.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2015-04-19 at 18:44 +0800, Caesar Wang wrote:
> --- a/arch/arm/mach-rockchip/Makefile
> +++ b/arch/arm/mach-rockchip/Makefile

+obj-$(CONFIG_PM_GENERIC_DOMAINS) += pm_domains.o

PM_GENERIC_DOMAINS is a bool symbol, so pm_domains.o can never be part
of a module. Is that correct?

> --- /dev/null
> +++ b/arch/arm/mach-rockchip/pm_domains.c

> +#include <linux/module.h>

This include could probably be dropped.

> +static const struct of_device_id rockchip_pm_domain_dt_match[] = {
> +	{
> +		.compatible = "rockchip,rk3288-power-controller",
> +		.data = (void *)&rk3288_pmu,
> +	},
> +	{ /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, rockchip_pm_domain_dt_match);

The MODULE_DEVICE_TABLE() macro will be preprocessed away for built-in
code, according to include/linux/module.h.

> +static struct platform_driver rockchip_pm_domain_driver = {
> +	.probe = rockchip_pm_domain_probe,
> +	.driver = {
> +		.name   = "rockchip-pm-domain",
> +		.owner  = THIS_MODULE,

According to include/linux/export.h THIS_MODULE is equivalent to NULL
for built-in code. So I think this line is not needed.

> +		.of_match_table = rockchip_pm_domain_dt_match,
> +		/*
> +		 * We can't forcibly eject devices form power domain,
> +		 * so we can't really remove power domains once they
> +		 * were added.
> +		 */
> +		.suppress_bind_attrs = true,
> +	},
> +};

Thanks,


Paul Bolle