public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] tools/lib/api: undefine _FORTIFY_SOURCE before setting it
@ 2015-04-21 23:19 Bobby Powers
  2015-05-01 10:14 ` [tip:perf/urgent] tools lib api: Undefine " tip-bot for Bobby Powers
  0 siblings, 1 reply; 2+ messages in thread
From: Bobby Powers @ 2015-04-21 23:19 UTC (permalink / raw)
  To: linux-kbuild, Kernel development list
  Cc: Bobby Powers, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
	Dirk Gouders, Arnaldo Carvalho de Melo, Jiri Olsa, Michal Marek

Some toolchains (like Hardened Gentoo) define _FORTIFY_SOURCE in the
built-in, default args.  This causes perf builds to fail with:

<command-line>:0:0: error: "_FORTIFY_SOURCE" redefined [-Werror]
<built-in>: note: this is the location of the previous definition
cc1: all warnings being treated as errors

To avoid this, undefine _FORTIFY_SOURCE before (possibly
re-)defining it in tools/lib/api.

v2 applies cleanly on top of already pulled kbuild changes for 4.1-rc1.

Signed-off-by: Bobby Powers <bobbypowers@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/lib/api/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/api/Makefile b/tools/lib/api/Makefile
index d8fe29f..8bd9606 100644
--- a/tools/lib/api/Makefile
+++ b/tools/lib/api/Makefile
@@ -16,7 +16,7 @@ MAKEFLAGS += --no-print-directory
 LIBFILE = $(OUTPUT)libapi.a
 
 CFLAGS := $(EXTRA_WARNINGS) $(EXTRA_CFLAGS)
-CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -D_FORTIFY_SOURCE=2 -fPIC
+CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fPIC
 CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
 
 RM = rm -f
-- 
2.3.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:perf/urgent] tools lib api: Undefine _FORTIFY_SOURCE before setting it
  2015-04-21 23:19 [PATCH v2] tools/lib/api: undefine _FORTIFY_SOURCE before setting it Bobby Powers
@ 2015-05-01 10:14 ` tip-bot for Bobby Powers
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Bobby Powers @ 2015-05-01 10:14 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: hpa, mingo, tglx, bobbypowers, linux-kernel, a.p.zijlstra, dirk,
	paulus, mmarek, acme, jolsa

Commit-ID:  de28c15daf60e9625bece22f13a091fac8d05f1d
Gitweb:     http://git.kernel.org/tip/de28c15daf60e9625bece22f13a091fac8d05f1d
Author:     Bobby Powers <bobbypowers@gmail.com>
AuthorDate: Tue, 21 Apr 2015 19:19:41 -0400
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 23 Apr 2015 17:08:23 -0300

tools lib api: Undefine _FORTIFY_SOURCE before setting it

Some toolchains (like Hardened Gentoo) define _FORTIFY_SOURCE in the
built-in, default args.  This causes perf builds to fail with:

<command-line>:0:0: error: "_FORTIFY_SOURCE" redefined [-Werror]
<built-in>: note: this is the location of the previous definition cc1:
all warnings being treated as errors

To avoid this, undefine _FORTIFY_SOURCE before (possibly re-)defining it
in tools/lib/api.

v2 applies cleanly on top of already pulled kbuild changes for 4.1-rc1.

Signed-off-by: Bobby Powers <bobbypowers@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Dirk Gouders <dirk@gouders.net>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kbuild@vger.kernel.org
Link: http://lkml.kernel.org/r/1429658381-3039-1-git-send-email-bobbypowers@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/api/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/api/Makefile b/tools/lib/api/Makefile
index d8fe29f..8bd9606 100644
--- a/tools/lib/api/Makefile
+++ b/tools/lib/api/Makefile
@@ -16,7 +16,7 @@ MAKEFLAGS += --no-print-directory
 LIBFILE = $(OUTPUT)libapi.a
 
 CFLAGS := $(EXTRA_WARNINGS) $(EXTRA_CFLAGS)
-CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -D_FORTIFY_SOURCE=2 -fPIC
+CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fPIC
 CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
 
 RM = rm -f

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-01 10:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-21 23:19 [PATCH v2] tools/lib/api: undefine _FORTIFY_SOURCE before setting it Bobby Powers
2015-05-01 10:14 ` [tip:perf/urgent] tools lib api: Undefine " tip-bot for Bobby Powers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox