linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Wang <yun.wang@profitbricks.com>
To: Roland Dreier <roland@kernel.org>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal@dev.mellanox.co.il>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Michael Wang <yun.wang@profitbricks.com>,
	Tom Tucker <tom@opengridcomputing.com>,
	Steve Wise <swise@opengridcomputing.com>,
	Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
	Christoph Raisch <raisch@de.ibm.com>,
	Mike Marciniszyn <infinipath@intel.com>,
	Eli Cohen <eli@mellanox.com>,
	Faisal Latif <faisal.latif@intel.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Haggai Eran <haggaie@mellanox.com>,
	Ira Weiny <ira.weiny@intel.com>, Tom Talpey <tom@talpey.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Doug Ledford <dledford@redhat.com>
Subject: [PATCH v6 00/26] IB/Verbs: IB Management Helpers
Date: Fri, 24 Apr 2015 14:23:24 +0200	[thread overview]
Message-ID: <1429878230-11749-1-git-send-email-yun.wang@profitbricks.com> (raw)

Since v5:
  * Thanks to Ira, Devesh for the review and testing :-)
  * Thanks for the comments from Steve, Tom, Jason, Hal, Devesh, Ira,
    Liran, Jason, Dave :-) Please remind me if anything missed :-P
  * Trivial fix for 4#
  * Drop the reform on acquiring link-layer in 9#
  * Drop cap_ipoib()

There are plenty of lengthy code to check the transport type of IB device,
or the link layer type of it's port, but actually we are just speculating
whether a particular management/feature is supported by the device/port.

Thus instead of inferring, we should have our own mechanism for IB management
capability/protocol/feature checking, several proposals below.

This patch set will reform the method of getting transport type, we will
now using query_transport() instead of inferring from transport and link
layer respectively, also we defined the new transport type to make the
concept more reasonable.

Mapping List:
		node-type	link-layer	old-transport	new-transport
nes		RNIC		ETH		IWARP		IWARP
amso1100	RNIC		ETH		IWARP		IWARP
cxgb3   	RNIC		ETH		IWARP		IWARP
cxgb4   	RNIC		ETH		IWARP		IWARP
usnic   	USNIC_UDP	ETH		USNIC_UDP	USNIC_UDP
ocrdma  	IB_CA		ETH		IB		IBOE
mlx4    	IB_CA		IB/ETH		IB		IB/IBOE
mlx5    	IB_CA		IB		IB		IB
ehca    	IB_CA		IB		IB		IB
ipath   	IB_CA		IB		IB		IB
mthca   	IB_CA		IB		IB		IB
qib     	IB_CA		IB		IB		IB

For example:
	if (transport == IB) && (link-layer == ETH)
will now become:
	if (query_transport() == IBOE)

Thus we will be able to get rid of the respective transport and link-layer
checking, and it will help us to add new protocol/Technology (like OPA) more
easier, also with the introduced management helpers, IB management logical
will be more clear and easier for extending.

Highlights:
    The patch set covered a wide range of IB stuff, thus for those who are
    familiar with the particular part, your suggestion would be invaluable ;-)

    Patch 1#~15# included all the logical reform, 16#~25# introduced the
    management helpers, 26#~27# do clean up.

    we appreciate for those one who have the HW willing to provide Tested-by :-)

    Doug suggested the bitmask mechanism:
	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html
    which could be the plan for future reforming, we prefer that to be another
    series which focus on semantic and performance.

    This patch-set is somewhat 'bloated' now and it may be a good timing for
    staging, I'd like to suggest we focus on improving existed helpers and push
    all the further reforms into next series ;-)

    We now have a repository based on latest infiniband/for-next with this
    series applied:
        git@github.com:ywang-pb/infiniband-wy.git

Proposals:
    Sean:
	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23339.html
    Doug:
	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23418.html
	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html
    Jason:
	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23425.html

Michael Wang (26):
  IB/Verbs: Implement new callback query_transport()
  IB/Verbs: Implement raw management helpers
  IB/Verbs: Reform IB-core mad/agent/user_mad
  IB/Verbs: Reform IB-core cm
  IB/Verbs: Reform IB-core sa_query
  IB/Verbs: Reform IB-core multicast
  IB/Verbs: Reform IB-ulp ipoib
  IB/Verbs: Reform IB-ulp xprtrdma
  IB/Verbs: Reform IB-core verbs
  IB/Verbs: Reform cm related part in IB-core cma/ucm
  IB/Verbs: Reform route related part in IB-core cma
  IB/Verbs: Reform mcast related part in IB-core cma
  IB/Verbs: Reserve legacy transport type in 'dev_addr'
  IB/Verbs: Reform cma_acquire_dev()
  IB/Verbs: Reform rest part in IB-core cma
  IB/Verbs: Use management helper cap_ib_mad()
  IB/Verbs: Use management helper cap_ib_smi()
  IB/Verbs: Use management helper cap_ib_cm()
  IB/Verbs: Use management helper cap_iw_cm()
  IB/Verbs: Use management helper cap_ib_sa()
  IB/Verbs: Use management helper cap_ib_mcast()
  IB/Verbs: Use management helper cap_read_multi_sge()
  IB/Verbs: Use management helper cap_af_ib()
  IB/Verbs: Use management helper cap_eth_ah()
  IB/Verbs: Clean up rdma_ib_or_iboe()
  IB/Verbs: Cleanup rdma_node_get_transport()

 drivers/infiniband/core/agent.c              |   2 +-
 drivers/infiniband/core/cm.c                 |  20 +-
 drivers/infiniband/core/cma.c                | 282 ++++++++++++---------------
 drivers/infiniband/core/device.c             |   1 +
 drivers/infiniband/core/mad.c                |  43 ++--
 drivers/infiniband/core/multicast.c          |  12 +-
 drivers/infiniband/core/sa_query.c           |  30 +--
 drivers/infiniband/core/ucm.c                |   3 +-
 drivers/infiniband/core/ucma.c               |  25 +--
 drivers/infiniband/core/user_mad.c           |  26 ++-
 drivers/infiniband/core/verbs.c              |  31 +--
 drivers/infiniband/hw/amso1100/c2_provider.c |   7 +
 drivers/infiniband/hw/cxgb3/iwch_provider.c  |   7 +
 drivers/infiniband/hw/cxgb4/provider.c       |   7 +
 drivers/infiniband/hw/ehca/ehca_hca.c        |   6 +
 drivers/infiniband/hw/ehca/ehca_iverbs.h     |   3 +
 drivers/infiniband/hw/ehca/ehca_main.c       |   1 +
 drivers/infiniband/hw/ipath/ipath_verbs.c    |   7 +
 drivers/infiniband/hw/mlx4/main.c            |  10 +
 drivers/infiniband/hw/mlx5/main.c            |   7 +
 drivers/infiniband/hw/mthca/mthca_provider.c |   7 +
 drivers/infiniband/hw/nes/nes_verbs.c        |   6 +
 drivers/infiniband/hw/ocrdma/ocrdma_main.c   |   1 +
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c  |   6 +
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.h  |   3 +
 drivers/infiniband/hw/qib/qib_verbs.c        |   7 +
 drivers/infiniband/hw/usnic/usnic_ib_main.c  |   1 +
 drivers/infiniband/hw/usnic/usnic_ib_verbs.c |   6 +
 drivers/infiniband/hw/usnic/usnic_ib_verbs.h |   2 +
 drivers/infiniband/ulp/ipoib/ipoib_main.c    |  15 +-
 include/rdma/ib_verbs.h                      | 169 +++++++++++++++-
 net/sunrpc/xprtrdma/svc_rdma_recvfrom.c      |   4 +-
 net/sunrpc/xprtrdma/svc_rdma_transport.c     |  47 ++---
 33 files changed, 503 insertions(+), 301 deletions(-)

-- 
2.1.0


             reply	other threads:[~2015-04-24 12:34 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 12:23 Michael Wang [this message]
2015-04-24 12:23 ` [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport() Michael Wang
2015-04-24 14:29   ` Tom Talpey
2015-04-24 14:35     ` Michael Wang
2015-04-24 14:46       ` Tom Talpey
2015-04-24 16:00         ` Doug Ledford
2015-04-24 15:12   ` Liran Liss
2015-04-27  7:39     ` Michael Wang
2015-04-27 21:52       ` ira.weiny
2015-04-28  0:16         ` Tom Talpey
2015-04-28  0:36           ` Doug Ledford
2015-04-28  0:53             ` Tom Talpey
2015-04-28  1:24               ` Doug Ledford
2015-04-28  1:49                 ` Tom Talpey
2015-04-28  6:14                   ` Hefty, Sean
2015-04-28 19:50                     ` Dave Goodell (dgoodell)
2015-04-28 19:53                       ` Hefty, Sean
2015-04-28 20:17                         ` Dave Goodell (dgoodell)
2015-04-28 14:29                 ` Michael Wang
2015-04-28 18:56                 ` Jason Gunthorpe
2015-04-28 19:11                   ` Or Gerlitz
2015-04-28 20:02                     ` Doug Ledford
2015-04-28 20:03                   ` Doug Ledford
2015-04-24 12:23 ` [PATCH v6 02/26] IB/Verbs: Implement raw management helpers Michael Wang
2015-04-24 15:15   ` Liran Liss
2015-04-24 16:29     ` Jason Gunthorpe
2015-04-27  7:41       ` Michael Wang
2015-04-24 12:23 ` [PATCH v6 03/26] IB/Verbs: Reform IB-core mad/agent/user_mad Michael Wang
2015-04-24 12:23 ` [PATCH v6 04/26] IB/Verbs: Reform IB-core cm Michael Wang
2015-04-24 12:23 ` [PATCH v6 05/26] IB/Verbs: Reform IB-core sa_query Michael Wang
2015-04-24 12:23 ` [PATCH v6 06/26] IB/Verbs: Reform IB-core multicast Michael Wang
2015-04-24 12:23 ` [PATCH v6 07/26] IB/Verbs: Reform IB-ulp ipoib Michael Wang
2015-04-24 12:23 ` [PATCH v6 08/26] IB/Verbs: Reform IB-ulp xprtrdma Michael Wang
2015-04-24 12:23 ` [PATCH v6 09/26] IB/Verbs: Reform IB-core verbs Michael Wang
2015-04-24 12:23 ` [PATCH v6 10/26] IB/Verbs: Reform cm related part in IB-core cma/ucm Michael Wang
2015-04-24 12:23 ` [PATCH v6 11/26] IB/Verbs: Reform route related part in IB-core cma Michael Wang
2015-04-24 12:23 ` [PATCH v6 12/26] IB/Verbs: Reform mcast " Michael Wang
2015-04-24 12:23 ` [PATCH v6 13/26] IB/Verbs: Reserve legacy transport type in 'dev_addr' Michael Wang
2015-04-24 12:23 ` [PATCH v6 14/26] IB/Verbs: Reform cma_acquire_dev() Michael Wang
2015-04-24 12:23 ` [PATCH v6 15/26] IB/Verbs: Reform rest part in IB-core cma Michael Wang
2015-04-24 12:23 ` [PATCH v6 16/26] IB/Verbs: Use management helper cap_ib_mad() Michael Wang
2015-04-24 12:23 ` [PATCH v6 17/26] IB/Verbs: Use management helper cap_ib_smi() Michael Wang
2015-04-24 12:23 ` [PATCH v6 18/26] IB/Verbs: Use management helper cap_ib_cm() Michael Wang
2015-04-24 12:23 ` [PATCH v6 19/26] IB/Verbs: Use management helper cap_iw_cm() Michael Wang
2015-04-24 12:23 ` [PATCH v6 20/26] IB/Verbs: Use management helper cap_ib_sa() Michael Wang
2015-04-24 12:23 ` [PATCH v6 21/26] IB/Verbs: Use management helper cap_ib_mcast() Michael Wang
2015-04-24 12:23 ` [PATCH v6 22/26] IB/Verbs: Use management helper cap_read_multi_sge() Michael Wang
2015-04-24 12:23 ` [PATCH v6 23/26] IB/Verbs: Use management helper cap_af_ib() Michael Wang
2015-04-24 12:23 ` [PATCH v6 24/26] IB/Verbs: Use management helper cap_eth_ah() Michael Wang
2015-04-24 12:23 ` [PATCH v6 25/26] IB/Verbs: Clean up rdma_ib_or_iboe() Michael Wang
2015-04-24 12:23 ` [PATCH v6 26/26] IB/Verbs: Cleanup rdma_node_get_transport() Michael Wang
2015-04-24 13:13 ` [PATCH v6 00/26] IB/Verbs: IB Management Helpers Michael Wang
2015-04-27  7:19   ` Devesh Sharma
2015-04-27  7:44     ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429878230-11749-1-git-send-email-yun.wang@profitbricks.com \
    --to=yun.wang@profitbricks.com \
    --cc=dledford@redhat.com \
    --cc=eli@mellanox.com \
    --cc=faisal.latif@intel.com \
    --cc=haggaie@mellanox.com \
    --cc=hal@dev.mellanox.co.il \
    --cc=hnguyen@de.ibm.com \
    --cc=infinipath@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=raisch@de.ibm.com \
    --cc=roland@kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=swise@opengridcomputing.com \
    --cc=tom@opengridcomputing.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).