From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757105AbbDXQ2f (ORCPT ); Fri, 24 Apr 2015 12:28:35 -0400 Received: from g4t3426.houston.hp.com ([15.201.208.54]:49566 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbbDXQ2c (ORCPT ); Fri, 24 Apr 2015 12:28:32 -0400 Message-ID: <1429891777.16996.58.camel@misato.fc.hp.com> Subject: Re: [Linux-nvdimm] [PATCH 08/21] nd: ndctl.h, the nd ioctl abi From: Toshi Kani To: Dan Williams Cc: linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Robert Moore , linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Date: Fri, 24 Apr 2015 10:09:37 -0600 In-Reply-To: <1429890991.16996.55.camel@misato.fc.hp.com> References: <20150418013256.25237.96403.stgit@dwillia2-desk3.amr.corp.intel.com> <20150418013557.25237.81354.stgit@dwillia2-desk3.amr.corp.intel.com> <1429890991.16996.55.camel@misato.fc.hp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-04-24 at 09:56 -0600, Toshi Kani wrote: > On Fri, 2015-04-17 at 21:35 -0400, Dan Williams wrote: > > Most configuration of the nd-subsystem is done via nd-sysfs. However, > > the NFIT specification defines a small set of messages that can be > > passed to the subsystem via platform-firmware-defined methods. The > > command set (as of the current version of the NFIT-DSM spec) is: > > > > NFIT_CMD_SMART: media health and diagnostics > > NFIT_CMD_GET_CONFIG_SIZE: size of the label space > > NFIT_CMD_GET_CONFIG_DATA: read label > > NFIT_CMD_SET_CONFIG_DATA: write label > > NFIT_CMD_VENDOR: vendor-specific command passthrough > > NFIT_CMD_ARS_CAP: report address-range-scrubbing capabilities > > NFIT_CMD_START_ARS: initiate scrubbing > > NFIT_CMD_QUERY_ARS: report on scrubbing state > > NFIT_CMD_SMART_THRESHOLD: configure alarm thresholds for smart events > > "nd/bus.c" provides two features, 1) the top level ND bus driver which > is the central part of the ND, and 2) the ioctl interface specific to > the example-DSM-interface. I think the example-DSM-specific part should > be put into an example-DSM-support module, so that the ND can support > other _DSMs as necessary. Also, _DSM needs to be handled as optional. And the same for "nd/acpi.c", which is 1) the ACPI0012 handler, and 2) the example-DSM-support module. I think they need to be separated. Thanks, -Toshi