From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758764AbbDYJJX (ORCPT <rfc822;w@1wt.eu>);
	Sat, 25 Apr 2015 05:09:23 -0400
Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:47166 "EHLO
	lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1758761AbbDYJJV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 25 Apr 2015 05:09:21 -0400
Message-ID: <1429952957.2927.95.camel@x220>
Subject: Re: [RFC PATCH] power: axp288_charger: axp288 charger driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Cc: linux-kernel@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
        Lee Jones <lee.jones@linaro.org>, Samuel Ortiz <sameo@linux.intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>
Date: Sat, 25 Apr 2015 11:09:17 +0200
In-Reply-To: <1429895192-11204-1-git-send-email-ramakrishna.pallala@intel.com>
References: <1429895192-11204-1-git-send-email-ramakrishna.pallala@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Just a nit: a license mismatch.

On Fri, 2015-04-24 at 22:36 +0530, Ramakrishna Pallala wrote:
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 4091fb0..c7d7e8b 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> --- /dev/null
> +++ b/drivers/power/axp288_charger.c

> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	See the GNU
> + * General Public License for more details.

This states the license is GPL v2.

> +MODULE_LICENSE("GPL");

And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think either the license comment or the ident used in
the MODULE_LICENSE() macro should be changed.


Paul Bolle