From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Jes Sorensen <Jes.Sorensen@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 0/8] staging/rtl8xxx: delete ieee80211 constant duplication
Date: Mon, 27 Apr 2015 01:25:33 -0400 [thread overview]
Message-ID: <1430112341-21402-1-git-send-email-paul.gortmaker@windriver.com> (raw)
While looking at a non-staging wifi driver, I was searching for a constant
definition for an error code, and in addition to the expected one living
in the main include dir, I found a whole bunch of local copies in the
staging dir rtl8xxx wifi drivers. This duplication covers the families
of WLAN_STATUS_<text> and WLAN_REASON_<text> values.
While one can understand that these things were wholesale copied at one
point to simplify out of tree building, we don't want duplicated stuff
for drivers that are in tree. Even if they are in staging, they will
need cleanups like this if they ever want to get out of staging.
Some could be removed and trivially replaced with the associated include
of <linux/ieee80211.h> but for a couple of others a couple of struct
fields had to be renamed to align with the main include first, and a
struct namespace collision between the main include and the local ones
had to be resolved to allow the duplicate constant removal as well.
Compile tested only, but the changes seem trivial enough so as to be
presumably zero runtime impact (famous last words....)
---
Paul Gortmaker (8):
rtl8188eu: don't duplicate ieee80211 constants for status/reason
rtl8712: don't duplicate ieee80211 constants for status/reason
rtl8192u: don't trample on <linux/ieee80211.h> struct namespace
rtl8192u: promote auth_mode to a full 8 bits
rtl8192u: align local ieee80211_wmm_ac_param struct fields with global
rtl8192u: don't duplicate ieee80211 constants for status/auth/reason
rtl8192u: delete another embedded instance of generic reason codes
rtl8192e: delete local copy of iee80211 reason codes.
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 10 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +
drivers/staging/rtl8188eu/include/ieee80211.h | 29 +---
drivers/staging/rtl8188eu/include/wifi.h | 77 ----------
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +-
drivers/staging/rtl8192e/rtllib.h | 39 -----
drivers/staging/rtl8192e/rtllib_softmac.c | 3 +-
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 171 +++------------------
.../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 10 +-
.../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 26 ++--
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 76 ++++-----
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 32 ++--
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 14 +-
.../staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 48 +++---
drivers/staging/rtl8192u/r8192U_core.c | 12 +-
drivers/staging/rtl8712/ieee80211.h | 29 ----
18 files changed, 150 insertions(+), 435 deletions(-)
--
2.2.1
next reply other threads:[~2015-04-27 5:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 5:25 Paul Gortmaker [this message]
2015-04-27 5:25 ` [PATCH 1/8] rtl8188eu: don't duplicate ieee80211 constants for status/reason Paul Gortmaker
2015-04-27 5:25 ` [PATCH 2/8] rtl8712: " Paul Gortmaker
2015-04-27 5:25 ` [PATCH 3/8] rtl8192u: don't trample on <linux/ieee80211.h> struct namespace Paul Gortmaker
2015-04-30 13:52 ` Jes Sorensen
2015-04-30 14:22 ` Paul Gortmaker
2015-04-30 14:30 ` Jes Sorensen
2015-04-27 5:25 ` [PATCH 4/8] rtl8192u: promote auth_mode to a full 8 bits Paul Gortmaker
2015-04-27 5:25 ` [PATCH 5/8] rtl8192u: align local ieee80211_wmm_ac_param struct fields with global Paul Gortmaker
2015-04-27 5:25 ` [PATCH 6/8] rtl8192u: don't duplicate ieee80211 constants for status/auth/reason Paul Gortmaker
2015-04-27 5:25 ` [PATCH 7/8] rtl8192u: delete another embedded instance of generic reason codes Paul Gortmaker
2015-04-27 5:25 ` [PATCH 8/8] rtl8192e: delete local copy of iee80211 " Paul Gortmaker
2015-04-27 17:12 ` [PATCH 0/8] staging/rtl8xxx: delete ieee80211 constant duplication Larry Finger
2015-06-17 16:32 ` Jakub Sitnicki
2015-06-17 18:01 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430112341-21402-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox