From: Ming Lin <mlin@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Kent Overstreet <kent.overstreet@gmail.com>,
Dongsu Park <dongsu.park@profitbricks.com>,
Ming Lin <mlin@kernel.org>, Christoph Hellwig <hch@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: [PATCH 10/10] Documentation: update notes in biovecs about arbitrarily sized bios
Date: Mon, 27 Apr 2015 23:48:37 -0700 [thread overview]
Message-ID: <1430203717-13307-11-git-send-email-mlin@kernel.org> (raw)
In-Reply-To: <1430203717-13307-1-git-send-email-mlin@kernel.org>
From: Dongsu Park <dongsu.park@profitbricks.com>
Update block/biovecs.txt so that it includes a note on what kind of
effects arbitrarily sized bios would bring to the block layer.
Also fix a trivial typo, bio_iter_iovec.
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Signed-off-by: Dongsu Park <dongsu.park@profitbricks.com>
Signed-off-by: Ming Lin <mlin@kernel.org>
---
Documentation/block/biovecs.txt | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/block/biovecs.txt b/Documentation/block/biovecs.txt
index 74a32ad..2568958 100644
--- a/Documentation/block/biovecs.txt
+++ b/Documentation/block/biovecs.txt
@@ -24,7 +24,7 @@ particular, presenting the illusion of partially completed biovecs so that
normal code doesn't have to deal with bi_bvec_done.
* Driver code should no longer refer to biovecs directly; we now have
- bio_iovec() and bio_iovec_iter() macros that return literal struct biovecs,
+ bio_iovec() and bio_iter_iovec() macros that return literal struct biovecs,
constructed from the raw biovecs but taking into account bi_bvec_done and
bi_size.
@@ -109,3 +109,11 @@ Other implications:
over all the biovecs in the new bio - which is silly as it's not needed.
So, don't use bi_vcnt anymore.
+
+ * The current interface allows the block layer to split bios as needed, so we
+ could eliminate a lot of complexity particularly in stacked drivers. Code
+ that creates bios can then create whatever size bios are convenient, and
+ more importantly stacked drivers don't have to deal with both their own bio
+ size limitations and the limitations of the underlying devices. Thus
+ there's no need to define ->merge_bvec_fn() callbacks for individual block
+ drivers.
--
1.9.1
prev parent reply other threads:[~2015-04-28 6:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 6:48 [RFC PATCH v2 00/10] simplify block layer based on immutable biovecs Ming Lin
2015-04-28 6:48 ` [PATCH 01/10] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-04-28 11:43 ` Christoph Hellwig
2015-04-28 16:01 ` Keith Busch
2015-05-06 6:08 ` Ming Lin
2015-05-06 6:48 ` Christoph Hellwig
2015-05-06 7:13 ` Ming Lin
2015-04-28 6:48 ` [PATCH 02/10] block: simplify bio_add_page() Ming Lin
2015-04-28 12:12 ` Christoph Hellwig
2015-04-29 5:42 ` Ming Lin
2015-04-28 6:48 ` [PATCH 03/10] block: allow __blk_queue_bounce() to handle bios larger than BIO_MAX_PAGES Ming Lin
2015-04-28 6:48 ` [PATCH 04/10] bcache: clean up hacks around bio_split_pool Ming Lin
2015-04-28 12:14 ` Christoph Hellwig
2015-04-29 5:43 ` Ming Lin
2015-04-28 6:48 ` [PATCH 05/10] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-04-28 6:48 ` [PATCH 06/10] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-04-28 6:48 ` [PATCH 07/10] block: kill merge_bvec_fn() completely Ming Lin
2015-04-28 17:31 ` Alasdair G Kergon
2015-04-29 6:32 ` Ming Lin
2015-04-28 22:09 ` NeilBrown
2015-05-04 7:47 ` Ming Lin
2015-05-06 7:10 ` Ming Lin
2015-05-06 7:26 ` Christoph Hellwig
2015-05-06 17:05 ` Ming Lin
2015-04-28 6:48 ` [PATCH 08/10] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-04-28 6:48 ` [PATCH 09/10] md/raid10: make sync_request_write() call bio_copy_data() Ming Lin
2015-04-28 6:48 ` Ming Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430203717-13307-11-git-send-email-mlin@kernel.org \
--to=mlin@kernel.org \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=dongsu.park@profitbricks.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).