From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933039AbbD1Hlv (ORCPT ); Tue, 28 Apr 2015 03:41:51 -0400 Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:56307 "EHLO lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932287AbbD1Hlt (ORCPT ); Tue, 28 Apr 2015 03:41:49 -0400 Message-ID: <1430206906.2411.25.camel@x220> Subject: Re: [PATCH v4] extcon-axp288: Add axp288 extcon driver support From: Paul Bolle To: Ramakrishna Pallala Cc: linux-kernel@vger.kernel.org, Chanwoo Choi , Lee Jones , Samuel Ortiz , Jacob Pan Date: Tue, 28 Apr 2015 09:41:46 +0200 In-Reply-To: <1430173962-22625-1-git-send-email-ramakrishna.pallala@intel.com> References: <1430173962-22625-1-git-send-email-ramakrishna.pallala@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only a license nit. On Tue, 2015-04-28 at 04:02 +0530, Ramakrishna Pallala wrote: > --- /dev/null > +++ b/drivers/extcon/extcon-axp288.c > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. This states the license is GPL v2 or later. > +MODULE_LICENSE("GPL v2"); And, according to include/linux/module.h, this states the license is (just) GPL v2. So I think that either the comment at the top of this file or the ident used in the MODULE_LICENSE() macro should be changed. Thanks, Paul Bolle