public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	pang.xunlei@zte.com.cn, Juri Lelli <juri.lelli@gmail.com>,
	linux-kernel@vger.kernel.org, linux-kernel-owner@vger.kernel.org,
	Xunlei Pang <pang.xunlei@linaro.org>
Subject: Re: [PATCH v6 2/3] sched/rt: Fix wrong SMP scheduler behavior for equal prio cases
Date: Tue, 28 Apr 2015 14:48:24 +0200	[thread overview]
Message-ID: <1430225304.3378.44.camel@gmail.com> (raw)
In-Reply-To: <20150428101910.GU23123@twins.programming.kicks-ass.net>

On Tue, 2015-04-28 at 12:19 +0200, Peter Zijlstra wrote:
> On Sun, Apr 26, 2015 at 11:58:51AM -0400, Steven Rostedt wrote:
> > I think what Xunlei is trying to say, is that we don't currently keep
> > FIFO when preemption or migration is involved. If a task is currently
> > running, strict FIFO denotes that it should run ahead of all other
> > tasks queued at its priority or less until it decides to schedule out.
> > But the issue is, if it gets preempted or migrates, it gets placed
> > behind other tasks of the same priority as itself, but it never
> > voluntarily relinquished the CPU.
> 
> So 1) FIFO is only defined for UP, anything SMP is well outside of the
> FIFO spec and therefore we cannot break it.
> 
> 2) The 'head' of the queue only has meaning on UP, with SMP there's 'n'
> heads, which of those heads is is the foremost head? That is, we're
> already lost order, you cannot reconstruct. This cannot be done without
> first defining order and then implementing that.

Good luck with that :)  Trying to preserve run order across the box led
me to a seemingly _endless_ supply of deadlocks while piddling with
preemptible spinning locks in rt.  Maybe you can pull that off, me it
gave serious headaches.

	-Mike


  reply	other threads:[~2015-04-28 12:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20  8:22 [PATCH v6 1/3] lib/plist: Provide plist_add_head() for nodes with the same prio Xunlei Pang
2015-04-20  8:22 ` [PATCH v6 2/3] sched/rt: Fix wrong SMP scheduler behavior for equal prio cases Xunlei Pang
2015-04-20 14:52   ` Steven Rostedt
2015-04-20 17:20     ` Peter Zijlstra
2015-04-20 17:48       ` Steven Rostedt
2015-04-20 23:45         ` Peter Zijlstra
2015-04-21 13:10           ` Steven Rostedt
     [not found]         ` <OFB1503F16.1E65406F-ON48257E2E.002B562D-48257E30.0008BFEB@zte.com.cn>
2015-04-23  3:01           ` Steven Rostedt
     [not found]             ` <OFE3B71874.C9D81693-ON48257E30.0024F69F-48257E30.0025E2D3@zte.com.cn>
2015-04-23 13:10               ` Steven Rostedt
2015-04-24 18:32               ` Peter Zijlstra
     [not found]                 ` <OF0B05B4FE.F40C0BE3-ON48257E32.004EF485-48257E32.00513DB3@zte.com.cn>
2015-04-25 18:23                   ` Peter Zijlstra
     [not found]                     ` <OFD410EB1E.5A02675A-ON48257E33.00309252-48257E33.003641FF@zte.com.cn>
2015-04-26 15:58                       ` Steven Rostedt
2015-04-28 10:19                         ` Peter Zijlstra
2015-04-28 12:48                           ` Mike Galbraith [this message]
2015-04-20  8:22 ` [PATCH v6 3/3] sched/rt: Check to push the task when changing its affinity Xunlei Pang
2015-04-20 16:06   ` Steven Rostedt
2015-04-20 14:42 ` [PATCH v6 1/3] lib/plist: Provide plist_add_head() for nodes with the same prio Steven Rostedt
2015-04-20 14:48 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430225304.3378.44.camel@gmail.com \
    --to=umgwanakikbuti@gmail.com \
    --cc=juri.lelli@gmail.com \
    --cc=linux-kernel-owner@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pang.xunlei@linaro.org \
    --cc=pang.xunlei@zte.com.cn \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox