From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751219AbbD3JYl (ORCPT <rfc822;w@1wt.eu>);
	Thu, 30 Apr 2015 05:24:41 -0400
Received: from mail-wg0-f53.google.com ([74.125.82.53]:35191 "EHLO
	mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750730AbbD3JYi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 30 Apr 2015 05:24:38 -0400
Message-ID: <1430385874.2400.13.camel@linaro.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add msm8916 CoreSight components
From: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Kumar Gala <galak@codeaurora.org>, Pratik Patel <pratikp@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-arm-msm@vger.kernel.org
Date: Thu, 30 Apr 2015 12:24:34 +0300
In-Reply-To: <CANLsYkxE9xieUW+OMgb4LbnJHRdCtTM=uzcwPzC6bs4x4pP3MA@mail.gmail.com>
References: <1430310000-10867-1-git-send-email-ivan.ivanov@linaro.org>
	 <1430310000-10867-3-git-send-email-ivan.ivanov@linaro.org>
	 <CANLsYkxE9xieUW+OMgb4LbnJHRdCtTM=uzcwPzC6bs4x4pP3MA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.13.7-fta1.2~trusty 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Wed, 2015-04-29 at 10:49 -0600, Mathieu Poirier wrote:
> On 29 April 2015 at 06:20, Ivan T. Ivanov ivanov@linaro.org> wrote:


> > +
> > +       funnel@821000 {
> > +               compatible = "arm,coresight-funnel", "arm,primecell";
> > +               reg = <0x821000 0x1000>;
> > +
> > +               clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
> > +               clock-names = "apb_pclk", "atclk";
> > +
> > +               ports {
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +                       port@4 {
> > +                               reg = <4>;
> > +                               funnel0_in4: endpoint {
> > +                                       slave-mode;
> > +                                       remote-endpoint = <&funnel1_out>;
> > +                               };
> > +                       };
> > +                       port@8 {
> > +                               reg = <0>;
> > +                               funnel0_out: endpoint {
> > +                                       remote-endpoint = <&etf_in>;
> > +                               };
> > +                       };
> 
> Please add a comment indicating what the other ports are connected to.
> 
> > +               };
> > +       };
> > +
> > +       replicator@824000 {
> > +               compatible = "qcom,coresight-replicator", "arm,primecell";
> > +               reg = <0x824000 0x1000>;
> > +
> > +               clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
> > +               clock-names = "apb_pclk", "atclk";
> > +
> > +               ports {
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +                       port@0 {
> > +                               reg = <0>;
> > +                               replicator_out0: endpoint {
> > +                                       remote-endpoint = <&etr_in>;
> > +                               };
> > +                       };
> > +                       port@1 {
> > +                               reg = <1>;
> > +                               replicator_out1: endpoint {
> > +                                       remote-endpoint = <&tpiu_in>;
> > +                               };
> > +                       };
> > +                       port@2 {
> > +                               reg = <0>;
> > +                               replicator_in: endpoint {
> > +                                       slave-mode;
> > +                                       remote-endpoint = <&etf_out>;
> > +                               };
> > +                       };
> 
> Same comment as with the funnel component.

Sorry, but what do you mean here?

Regards,
Ivan