From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: lee.jones@linaro.org
Cc: sameo@linux.intel.com, broonie@kernel.org, lgirdwood@gmail.com,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 10/10] mfd: wm5110: Add delay before releasing reset line
Date: Thu, 30 Apr 2015 10:48:07 +0100 [thread overview]
Message-ID: <1430387287-27777-11-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1430387287-27777-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On the wm5110 it is important the reset line is held for slightly longer
to ensure the device starts up well. This patch adds a 5mS delay for
this.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-core.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index f1ff68a..93e4d94 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -259,6 +259,16 @@ static inline void arizona_enable_reset(struct arizona *arizona)
static void arizona_disable_reset(struct arizona *arizona)
{
if (arizona->pdata.reset) {
+ switch (arizona->type) {
+ case WM5110:
+ case WM8280:
+ /* Meet requirements for minimum reset duration */
+ msleep(5);
+ break;
+ default:
+ break;
+ }
+
gpio_set_value_cansleep(arizona->pdata.reset, 1);
msleep(1);
}
--
1.7.2.5
next prev parent reply other threads:[~2015-04-30 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 9:47 [PATCH v3 00/10] wm5110 Boot Fixups Charles Keepax
2015-04-30 9:47 ` [PATCH v3 01/10] mfd: arizona: Use devres to manage reset GPIO Charles Keepax
2015-04-30 9:47 ` [PATCH v3 02/10] mfd: arizona: Factor out hard reset into helper functions Charles Keepax
2015-04-30 9:48 ` [PATCH v3 03/10] mfd: wm5102: Ensure we always boot the device fully Charles Keepax
2015-04-30 9:48 ` [PATCH v3 04/10] mfd: arizona: Fix formating/style issues in arizona_apply_hardware_patch Charles Keepax
2015-04-30 9:48 ` [PATCH v3 05/10] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch Charles Keepax
2015-04-30 9:48 ` [PATCH v3 06/10] mfd: wm5110: Add register patch required for low power sleep Charles Keepax
2015-04-30 9:48 ` [PATCH v3 07/10] regulator: arizona-ldo1: Add additional supported voltage Charles Keepax
2015-04-30 9:48 ` [PATCH v3 08/10] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode Charles Keepax
2015-04-30 9:48 ` [PATCH v3 09/10] mfd: arizona: Add better support for system suspend Charles Keepax
2015-04-30 9:48 ` Charles Keepax [this message]
2015-04-30 10:08 ` [PATCH v3 10/10] mfd: wm5110: Add delay before releasing reset line Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430387287-27777-11-git-send-email-ckeepax@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox