From: Paul Bolle <pebolle@tiscali.nl>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, marxin.liska@gmail.com, marex@denx.de,
rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor
Date: Thu, 30 Apr 2015 22:33:46 +0200 [thread overview]
Message-ID: <1430426026.2187.5.camel@x220> (raw)
In-Reply-To: <1430306845-7117-1-git-send-email-gabriele.mzt@gmail.com>
Just a nit: a license mismatch.
On Wed, 2015-04-29 at 13:27 +0200, Gabriele Mazzotta wrote:
> --- /dev/null
> +++ b/drivers/iio/light/acpi-als.c
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think either the comment at the top of this file or
the ident used in the MODULE_LICENSE() macro should be changed.
Paul Bolle
next prev parent reply other threads:[~2015-04-30 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 11:27 [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor Gabriele Mazzotta
2015-04-29 11:51 ` Gabriele Mazzotta
2015-04-29 14:33 ` Marek Vasut
2015-04-29 15:36 ` Gabriele Mazzotta
2015-04-30 9:44 ` Marek Vasut
2015-04-30 11:27 ` Gabriele Mazzotta
2015-04-30 11:30 ` Marek Vasut
2015-04-30 12:24 ` Daniel Baluta
2015-04-30 19:14 ` Gabriele Mazzotta
2015-04-30 20:33 ` Paul Bolle [this message]
2015-04-30 20:58 ` Marek Vasut
2015-05-01 16:12 ` Gabriele Mazzotta
2015-05-02 11:22 ` Jonathan Cameron
2015-05-02 11:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430426026.2187.5.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=gabriele.mzt@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=marxin.liska@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox