From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753374AbbEAHoE (ORCPT ); Fri, 1 May 2015 03:44:04 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:53565 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751072AbbEAHoB (ORCPT ); Fri, 1 May 2015 03:44:01 -0400 X-Listener-Flag: 11101 From: Yingjoe Chen To: Mark Rutland , Matthias Brugger , Thomas Gleixner , Arnd Bergmann , Olof Johansson CC: Rob Herring , Pawel Moll , Ian Campbell , Russell King , Daniel Lezcano , Jason Cooper , Catalin Marinas , Yingjoe Chen , Marc Carino , Lorenzo Pieralisi , , , , , , Sascha Hauer Subject: [PATCH 1/7] clocksource: mediatek: Don't run event_handler if it is NULL Date: Fri, 1 May 2015 15:43:24 +0800 Message-ID: <1430466210-22963-2-git-send-email-yingjoe.chen@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1430466210-22963-1-git-send-email-yingjoe.chen@mediatek.com> References: <1430466210-22963-1-git-send-email-yingjoe.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Spurious timer interrupt is noticed in mtk timer and cause kernel crash. In mtk_timer_interrupt(), only run event_handler if it is not NULL. Signed-off-by: Yingjoe Chen --- drivers/clocksource/mtk_timer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c index 68ab423..85e0ab5 100644 --- a/drivers/clocksource/mtk_timer.c +++ b/drivers/clocksource/mtk_timer.c @@ -143,7 +143,8 @@ static irqreturn_t mtk_timer_interrupt(int irq, void *dev_id) /* Acknowledge timer0 irq */ writel(GPT_IRQ_ACK(GPT_CLK_EVT), evt->gpt_base + GPT_IRQ_ACK_REG); - evt->dev.event_handler(&evt->dev); + if (evt->dev.event_handler) + evt->dev.event_handler(&evt->dev); return IRQ_HANDLED; } -- 1.8.1.1.dirty