From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Vinayak Holikatti <vinholikatti@gmail.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 09/11] drivers/scsi: include <module.h> for modular ufshcd-pltfrm code
Date: Fri, 01 May 2015 06:43:16 -0700 [thread overview]
Message-ID: <1430487796.2192.2.camel@HansenPartnership.com> (raw)
In-Reply-To: <554381AB.9060205@windriver.com>
On Fri, 2015-05-01 at 09:37 -0400, Paul Gortmaker wrote:
> On 15-04-30 10:35 PM, James Bottomley wrote:
> > On Thu, 2015-04-30 at 21:47 -0400, Paul Gortmaker wrote:
> >> This file is built off of a tristate Kconfig option and also contains
> >> modular function calls so it should explicitly include module.h to
> >> avoid compile breakage during header shuffles done in the future.
> >
> > I don't understand your logic. The ufs code made a design choice to
> > consolidate most headers for the hcd code in a local include (ufshcd.h),
> > which includes module.h, so why would they explicitly need it here as
> > well? And if we follow your logic, why wouldn't they also need to
> > duplicate everything else (like the scsi includes)?
>
> In my original build testing this file failed to compile once the
> modular code was moved from init.h to module.h as per the description
> in the 0/11.
Just as a point of principle, you didn't send the 0/11 patch, so I only
have this one to go by.
> Perhaps since that testing something else has changed. I will drop this
> patch and retest and if it no longer fails, then great.
Sounds good.
James
next prev parent reply other threads:[~2015-05-01 13:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 1:47 [PATCH 00/11] Fix implicit includes of <module.h> that will break Paul Gortmaker
2015-05-01 1:47 ` [PATCH 01/11] drivers/crypto: include <module.h> for modular caam code Paul Gortmaker
2015-05-01 3:24 ` Herbert Xu
2015-05-01 13:40 ` Paul Gortmaker
2015-05-01 1:47 ` [PATCH 02/11] drivers/clk: include <module.h> for clk-max77xxx modular code Paul Gortmaker
2015-05-01 21:37 ` Stephen Boyd
2015-05-02 0:29 ` Paul Gortmaker
2015-05-01 1:47 ` [PATCH 03/11] drivers/gpio: include <module.h> for modular crystalcove code Paul Gortmaker
2015-05-12 7:38 ` Linus Walleij
2015-05-01 1:47 ` [PATCH 04/11] drivers/gpu: include <module.h> for modular rockchip code Paul Gortmaker
2015-05-01 1:47 ` [PATCH 05/11] drivers/hsi: include <module.h> for modular omap_ssi code Paul Gortmaker
2015-05-01 1:47 ` [PATCH 06/11] drivers/net: include <module.h> for modular stmmac_platform code Paul Gortmaker
2015-05-04 3:40 ` David Miller
2015-05-01 1:47 ` [PATCH 07/11] drivers/pcmcia: include <module.h> for modular xxs1500_ss code Paul Gortmaker
2015-05-04 9:32 ` Wolfram Sang
2015-05-01 1:47 ` [PATCH 08/11] drivers/pcmcia: include <module.h> for modular max77802 code Paul Gortmaker
2015-05-01 10:11 ` Mark Brown
2015-05-01 13:34 ` Paul Gortmaker
2015-05-01 14:04 ` Mark Brown
2015-05-01 1:47 ` [PATCH 09/11] drivers/scsi: include <module.h> for modular ufshcd-pltfrm code Paul Gortmaker
2015-05-01 2:35 ` James Bottomley
2015-05-01 13:37 ` Paul Gortmaker
2015-05-01 13:43 ` James Bottomley [this message]
2015-05-01 1:47 ` [PATCH 10/11] drivers/staging: include <module.h> for modular android tegra_ion code Paul Gortmaker
2015-05-01 1:47 ` [PATCH 11/11] sh: mach-highlander/psw.c is tristate and should use module.h Paul Gortmaker
2015-06-03 21:18 ` [PATCH] drivers/cpufreq: include <module.h> for modular exynos-cpufreq.c code Paul Gortmaker
2015-06-04 2:00 ` Krzysztof Kozlowski
2015-06-04 2:32 ` Viresh Kumar
2015-06-15 23:47 ` Rafael J. Wysocki
2015-06-15 23:53 ` Krzysztof Kozlowski
2015-06-16 3:28 ` Paul Gortmaker
2015-06-16 15:29 ` Paul Gortmaker
2015-06-17 0:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430487796.2192.2.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox