From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753931AbbEAOOB (ORCPT ); Fri, 1 May 2015 10:14:01 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:57571 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753857AbbEAON7 (ORCPT ); Fri, 1 May 2015 10:13:59 -0400 X-Originating-IP: 83.155.44.161 Message-ID: <1430489635.3945.3.camel@hadess.net> Subject: Re: [PATCH v2] input: goodix: Check the 'buffer status' bit before reading data From: Bastien Nocera To: Paul Cercueil Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 01 May 2015 16:13:55 +0200 In-Reply-To: <1430484036-17541-1-git-send-email-paul@crapouillou.net> References: <1430484036-17541-1-git-send-email-paul@crapouillou.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.1 (3.16.1-1.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-05-01 at 14:40 +0200, Paul Cercueil wrote: > The MSB of the first byte read via I2C at the coordinates address > indicates whether the data is valid or ready (called "buffer status" > in > the datasheets) when an interrupt is raised. Previously, this bit was > ignored, which resulted in a lot of incorrect detections of "finger > removed" events. > > Signed-off-by: Paul Cercueil Signed-off-by: Bastien Nocera