Re: [PATCH 3.2 058/221] debugfs: leave freeing a symlink body until inode eviction

Ben Hutchings
2015-08-01T18:59:19Z

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

On Tue, 2015-06-16 at 17:33 +0100, Luis Henriques wrote:
> On Tue, May 05, 2015 at 02:16:39AM +0100, Ben Hutchings wrote:
[...]
> > [bwh: Backported to 3.2:
> > - Plumb in debugfs_super_operations, which we didn't previously
> > define
>
> It looks like this is introducing a regression[1]. Basically, simply
> running df shows an error:
>
> df: `/sys/kernel/debug': Function not implemented
>
> Doing 'strace df' shows the following:
>
> statfs64("/sys/kernel/debug", 84, 0xbfddc6bc) = -1 ENOSYS (Function
> not implemented)
>
> A quick test shows that adding '.statfs = simple_statfs' in the
> debugfs_super_operations struct fixes the problem, but I'm not sure
> that's the right thing to do.
[...]

It looks right to me. I've queued up this change; thanks a lot.

Ben.

--
Ben Hutchings
One of the nice things about standards is that there are so many of them.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]