From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760646AbbEEQ1n (ORCPT ); Tue, 5 May 2015 12:27:43 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:35128 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760630AbbEEQ1k (ORCPT ); Tue, 5 May 2015 12:27:40 -0400 From: Ingo Molnar To: linux-kernel@vger.kernel.org Cc: Andy Lutomirski , Borislav Petkov , Dave Hansen , Fenghua Yu , "H. Peter Anvin" , Linus Torvalds , Oleg Nesterov , Thomas Gleixner Subject: [PATCH 002/208] x86/fpu: Add comments to fpu__save() and restrict its export Date: Tue, 5 May 2015 18:23:42 +0200 Message-Id: <1430843228-13749-3-git-send-email-mingo@kernel.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1430843228-13749-1-git-send-email-mingo@kernel.org> References: <1430843228-13749-1-git-send-email-mingo@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add an explanation to fpu__save() and also don't export it to random modules - we don't want them to futz around with deep kernel internals. Reviewed-by: Borislav Petkov Cc: Andy Lutomirski Cc: Dave Hansen Cc: Fenghua Yu Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Oleg Nesterov Cc: Thomas Gleixner Signed-off-by: Ingo Molnar --- arch/x86/kernel/i387.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/i387.c b/arch/x86/kernel/i387.c index ec1a744eb853..ac47278cde71 100644 --- a/arch/x86/kernel/i387.c +++ b/arch/x86/kernel/i387.c @@ -117,6 +117,9 @@ void __kernel_fpu_end(void) } EXPORT_SYMBOL(__kernel_fpu_end); +/* + * Save the FPU state (initialize it if necessary): + */ void fpu__save(struct task_struct *tsk) { preempt_disable(); @@ -130,7 +133,7 @@ void fpu__save(struct task_struct *tsk) } preempt_enable(); } -EXPORT_SYMBOL(fpu__save); +EXPORT_SYMBOL_GPL(fpu__save); unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu; unsigned int xstate_size; -- 2.1.0