From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] xfs: fix inode count underrun
Date: Wed, 6 May 2015 08:01:37 +1000 [thread overview]
Message-ID: <1430863299-9341-1-git-send-email-david@fromorbit.com> (raw)
Hi folks,
With the conversion of XFS to use the generic per-cpu superblocks, I
overlooked the fact that the update batch size is important to the
accuracy of the comparison function. Using different batch sizes
means percpu_counter_compare() doesn't detect when it should fall
back to percpu_counter_sum() for accuracy correctly, resulting in
counter comparisons being inaccurate. This leads to problems with
zero threshold detection in XFS.
To fix, add __percpu_counter_compare() to take a caller supplied
batch size. This fixes the XFS regression introduced in 4.1-rc1.
-Dave.
next reply other threads:[~2015-05-05 22:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 22:01 Dave Chinner [this message]
2015-05-05 22:01 ` [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare() Dave Chinner
2015-05-06 4:36 ` Christoph Hellwig
2015-05-06 4:46 ` Christoph Hellwig
2015-05-06 5:43 ` Dave Chinner
2015-05-06 5:53 ` Dave Chinner
2015-05-06 6:11 ` Dave Chinner
2015-05-05 22:01 ` [PATCH 2/2] xfs: inode counter needs to use __percpu_counter_compare Dave Chinner
2015-05-06 4:38 ` Christoph Hellwig
2015-05-06 5:45 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430863299-9341-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox