From: Stephen Boyd <sboyd@codeaurora.org>
To: Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Alex Elder <elder@linaro.org>, Tim Kryger <tim.kryger@linaro.org>
Subject: [PATCH 05/19] clk: bcm/kona: Remove ccu_list
Date: Wed, 6 May 2015 00:39:42 -0700 [thread overview]
Message-ID: <1430897996-11597-6-git-send-email-sboyd@codeaurora.org> (raw)
In-Reply-To: <1430897996-11597-1-git-send-email-sboyd@codeaurora.org>
This list doesn't look to be used. Let's remove it and any
associated code that would be manipulating this list. This also
silences this error:
drivers/clk/bcm/clk-kona-setup.c:24:1: warning: symbol 'ccu_list' was not declared. Should it be static?
Cc: Alex Elder <elder@linaro.org>
Cc: Tim Kryger <tim.kryger@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/clk/bcm/clk-kona-setup.c | 4 ----
drivers/clk/bcm/clk-kona.h | 2 --
2 files changed, 6 deletions(-)
diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c
index e5aededdd322..deaa7f962b84 100644
--- a/drivers/clk/bcm/clk-kona-setup.c
+++ b/drivers/clk/bcm/clk-kona-setup.c
@@ -21,8 +21,6 @@
#define selector_clear_exists(sel) ((sel)->width = 0)
#define trigger_clear_exists(trig) FLAG_CLEAR(trig, TRIG, EXISTS)
-LIST_HEAD(ccu_list); /* The list of set up CCUs */
-
/* Validity checking */
static bool ccu_data_offsets_valid(struct ccu_data *ccu)
@@ -773,7 +771,6 @@ static void kona_ccu_teardown(struct ccu_data *ccu)
of_clk_del_provider(ccu->node); /* safe if never added */
ccu_clks_teardown(ccu);
- list_del(&ccu->links);
of_node_put(ccu->node);
ccu->node = NULL;
iounmap(ccu->base);
@@ -847,7 +844,6 @@ void __init kona_dt_ccu_setup(struct ccu_data *ccu,
goto out_err;
}
ccu->node = of_node_get(node);
- list_add_tail(&ccu->links, &ccu_list);
/*
* Set up each defined kona clock and save the result in
diff --git a/drivers/clk/bcm/clk-kona.h b/drivers/clk/bcm/clk-kona.h
index 6849a64baf6d..906576ec97b6 100644
--- a/drivers/clk/bcm/clk-kona.h
+++ b/drivers/clk/bcm/clk-kona.h
@@ -480,7 +480,6 @@ struct ccu_data {
spinlock_t lock; /* serialization lock */
bool write_enabled; /* write access is currently enabled */
struct ccu_policy policy;
- struct list_head links; /* for ccu_list */
struct device_node *node;
struct clk_onecell_data clk_data;
const char *name;
@@ -492,7 +491,6 @@ struct ccu_data {
#define KONA_CCU_COMMON(_prefix, _name, _ccuname) \
.name = #_name "_ccu", \
.lock = __SPIN_LOCK_UNLOCKED(_name ## _ccu_data.lock), \
- .links = LIST_HEAD_INIT(_name ## _ccu_data.links), \
.clk_data = { \
.clk_num = _prefix ## _ ## _ccuname ## _CCU_CLOCK_COUNT, \
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-06 7:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 7:39 [PATCH 00/19] Fix sparse errors in drivers/clk/ Stephen Boyd
2015-05-06 7:39 ` [PATCH 01/19] clk: gpio-gate: Don't export __init functions Stephen Boyd
2015-05-06 7:39 ` [PATCH 02/19] clk: Silence sparse warnings about __clk_{get,put}() Stephen Boyd
2015-05-06 7:39 ` [PATCH 03/19] clk: max-gen: Silence sparse warnings Stephen Boyd
2015-05-06 9:23 ` Javier Martinez Canillas
2015-05-06 7:39 ` [PATCH 04/19] clk: bcm/kona: " Stephen Boyd
2015-05-06 13:21 ` Alex Elder
2015-05-06 7:39 ` Stephen Boyd [this message]
2015-05-06 13:23 ` [PATCH 05/19] clk: bcm/kona: Remove ccu_list Alex Elder
2015-05-06 7:39 ` [PATCH 06/19] clk: berlin: Silence sparse warning Stephen Boyd
2015-05-06 22:28 ` Sebastian Hesselbarth
2015-05-06 7:39 ` [PATCH 07/19] clk: hix5hd2: Silence sparse warnings Stephen Boyd
2015-05-06 8:55 ` zhangfei
2015-05-06 7:39 ` [PATCH 08/19] clk: samsung: " Stephen Boyd
2015-05-06 10:53 ` Sylwester Nawrocki
2015-05-06 7:39 ` [PATCH 09/19] clk: emev2: " Stephen Boyd
2015-05-07 4:36 ` Simon Horman
2015-05-07 5:17 ` Stephen Boyd
2015-05-07 5:31 ` Simon Horman
2015-05-06 7:39 ` [PATCH 10/19] clk: sirf: " Stephen Boyd
2015-05-06 7:39 ` [PATCH 11/19] clk: socfpga: Silence sparse warning Stephen Boyd
2015-05-06 7:39 ` [PATCH 12/19] clk: st: Silence sparse warnings Stephen Boyd
2015-05-06 7:39 ` [PATCH 13/19] clk: ti: " Stephen Boyd
2015-05-06 8:15 ` Peter Ujfalusi
2015-05-07 8:16 ` Tero Kristo
2015-05-06 7:39 ` [PATCH 14/19] clk: versatile: " Stephen Boyd
2015-05-06 10:31 ` Pawel Moll
2015-05-06 7:39 ` [PATCH 15/19] clk: socfpga: Silence sparse warning Stephen Boyd
2015-05-06 7:39 ` [PATCH 16/19] clk: mmp: Silence sparse warnings Stephen Boyd
2015-05-06 7:39 ` [PATCH 17/19] clk: xgene: " Stephen Boyd
2015-05-06 7:39 ` [PATCH 18/19] clk: moxart: " Stephen Boyd
2015-05-06 7:39 ` [PATCH 19/19] clk: u300: " Stephen Boyd
2015-05-12 10:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430897996-11597-6-git-send-email-sboyd@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=elder@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox