From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751378AbbEGQj2 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 May 2015 12:39:28 -0400
Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:54752 "EHLO
	lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750726AbbEGQjZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 May 2015 12:39:25 -0400
Message-ID: <1431016761.8171.79.camel@x220>
Subject: Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight
 Replicator driver
From: Paul Bolle <pebolle@tiscali.nl>
To: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
        Kumar Gala <galak@codeaurora.org>,
        Pratik Patel <pratikp@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Date: Thu, 07 May 2015 18:39:21 +0200
In-Reply-To: <1431010007.21307.10.camel@linaro.org>
References: <1430310000-10867-1-git-send-email-ivan.ivanov@linaro.org>
	 <1430310000-10867-2-git-send-email-ivan.ivanov@linaro.org>
	 <1430427225.2187.15.camel@x220> <1431010007.21307.10.camel@linaro.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-05-07 at 17:46 +0300, Ivan T. Ivanov wrote:
> Thank you. I am going to fallow approach taken by Mathieu in [1].
> Is this OK with you?

I'm OK with anything that is coherent (ie, anything better than built-in
only code cross-dressing as modular code). I think Mathieu's approach
clears that bar. (Please note that macros like module_amba_driver() are
basically just a pet peeve.)

And, at the end of the day, what matters is what the maintainer of this
code accepts. I'm not the maintainer here.

Thanks,


Paul Bolle