Re: [PATCH] tools/thermal: tmon: fixed the 'make install' command

Zhang Rui
2015-05-08T03:05:03Z

On Thu, 2015-05-07 at 13:31 -0700, Jacob Pan wrote:
> On Fri, 8 May 2015 03:39:04 +0930
> Anand Moon <linux.amoon@gmail.com> wrote:
>
> > To install tmon we issue "make install" which produces bellow error.
> >
> looks good, there is no config file for now.
>
> Thanks for the fix.
> Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
>
patch applied. Thanks!

BTW, next time when sending a thermal related change, please cc
linux-pm@vger.kernel.org, or else the change may got because we usually
rely on https://patchwork.kernel.org/project/linux-pm/list/ to review
and scrub the patches. :)

thanks,
rui

> > root@odroidxu3:/usr/src/odroidxu3-4.y-testing/tools/thermal/tmon#
> > make install mkdir -p /usr/bin
> > install -m 755 -p "tmon" "/usr/bin/tmon"
> > mkdir -p /
> > install -m 644 -p "" "/"
> > install: cannot stat ‘’: No such file or directory
> > make: [install] Error 1 (ignored)
> >
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> > tools/thermal/tmon/Makefile | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon/Makefile
> > index 0788621..2e83dd3 100644
> > --- a/tools/thermal/tmon/Makefile
> > +++ b/tools/thermal/tmon/Makefile
> > @@ -12,10 +12,6 @@ TARGET=tmon
> > INSTALL_PROGRAM=install -m 755 -p
> > DEL_FILE=rm -f
> >
> > -INSTALL_CONFIGFILE=install -m 644 -p
> > -CONFIG_FILE=
> > -CONFIG_PATH=
> > -
> > # Static builds might require -ltinfo, for instance
> > ifneq ($(findstring -static, $(LDFLAGS)),)
> > STATIC := --static
> > @@ -38,13 +34,9 @@ valgrind: tmon
> > install:
> > - mkdir -p $(INSTALL_ROOT)/$(BINDIR)
> > - $(INSTALL_PROGRAM) "$(TARGET)"
> > "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> > - - mkdir -p $(INSTALL_ROOT)/$(CONFIG_PATH)
> > - - $(INSTALL_CONFIGFILE) "$(CONFIG_FILE)"
> > "$(INSTALL_ROOT)/$(CONFIG_PATH)"
> > uninstall:
> > $(DEL_FILE) "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> > - $(CONFIG_FILE) "$(CONFIG_PATH)"
> > -
> >
> > clean:
> > find . -name "*.o" | xargs $(DEL_FILE)
>
> [Jacob Pan]