public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Ramneek Mehresh <ramneek.mehresh@freescale.com>
Cc: linux-kernel@vger.kernel.org, balbi@ti.com,
	linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH 10/10] usb:fsl:otg: Make fsl otg driver as tristate
Date: Fri, 08 May 2015 10:35:39 +0200	[thread overview]
Message-ID: <1431074139.11180.7.camel@x220> (raw)
In-Reply-To: <1431002836-9711-10-git-send-email-ramneek.mehresh@freescale.com>

On Thu, 2015-05-07 at 18:17 +0530, Ramneek Mehresh wrote:
> Provide option to load fsl otg driver as loadable
> module

(Full stop at the end of that sentence, please.)

In case anyone is wondering: this is all that's needed to allow the
build of a phy-fsl-usb.ko module because the code already contains the
required module specific boilerplate. Actually, that boilerplate has
always been there since this driver was added in v3.0, as a built-in
only driver, through commit 0807c500a1a6 ("USB: add Freescale USB OTG
Transceiver driver").

(Of course, this assumes building modular and loading the module
actually works, none of which I have tried myself.)

> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> ---
>  drivers/usb/phy/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index 2175678..4927905 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -19,7 +19,7 @@ config AB8500_USB
>  	  in host mode, low speed.
>  
>  config FSL_USB2_OTG
> -	bool "Freescale USB OTG Transceiver Driver"
> +	tristate "Freescale USB OTG Transceiver Driver"
>  	depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM && PM
>  	select USB_OTG
>  	select USB_PHY


Paul Bolle


      reply	other threads:[~2015-05-08  8:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 12:47 [PATCH 01/10] usb:fsl:otg: Add controller version based ULPI and UTMI phy Ramneek Mehresh
2015-05-07 12:47 ` [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for EHCI drv Ramneek Mehresh
2015-05-07 14:46   ` Alan Stern
2015-05-08  5:03     ` Ramneek Mehresh
2015-05-08 14:26       ` Alan Stern
2015-05-11  5:18         ` Ramneek Mehresh
2015-05-07 12:47 ` [PATCH 03/10] usb:fsl:otg: Add support to add/remove usb host driver Ramneek Mehresh
2015-05-07 14:45   ` Alan Stern
2015-05-07 12:47 ` [PATCH 04/10] usb:fsl:otg: Signal host drv when host is otg Ramneek Mehresh
2015-05-07 12:47 ` [PATCH 05/10] usb:fsl:otg: Modify otg_event to start host drv Ramneek Mehresh
2015-05-07 12:47 ` [PATCH 06/10] usb:fsl:otg: Combine host/gadget start/resume for ID change Ramneek Mehresh
2015-05-07 12:47 ` [PATCH 07/10] usb:fsl:otg: Remove host drv upon otg bring-up Ramneek Mehresh
2015-05-07 12:47 ` [PATCH 08/10] usb:fsl:otg: Add host-gadget drv sync delay Ramneek Mehresh
2015-05-07 12:47 ` [PATCH 09/10] usb:fsl:otg: Resolve OTG crash issue with another host Ramneek Mehresh
2015-05-07 13:01   ` Sergei Shtylyov
2015-05-08  5:28     ` Ramneek Mehresh
2015-05-07 12:47 ` [PATCH 10/10] usb:fsl:otg: Make fsl otg driver as tristate Ramneek Mehresh
2015-05-08  8:35   ` Paul Bolle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431074139.11180.7.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ramneek.mehresh@freescale.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox