From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753821AbbEHNsF (ORCPT ); Fri, 8 May 2015 09:48:05 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:36502 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797AbbEHNsB (ORCPT ); Fri, 8 May 2015 09:48:01 -0400 Message-ID: <1431092877.21307.18.camel@linaro.org> Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: Add msm8916 CoreSight components From: "Ivan T. Ivanov" To: Mathieu Poirier Cc: Kumar Gala , Pratik Patel , Catalin Marinas , Will Deacon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-arm-msm@vger.kernel.org Date: Fri, 08 May 2015 16:47:57 +0300 In-Reply-To: References: <1431012969-16338-1-git-send-email-ivan.ivanov@linaro.org> <1431012969-16338-3-git-send-email-ivan.ivanov@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-05-08 at 07:38 -0600, Mathieu Poirier wrote: > On 7 May 2015 at 09:36, Ivan T. Ivanov ivanov@linaro.org> wrote: > > Add initial set of CoreSight components found on Qualcomm's 8x16 chipset. > > > > > > +       replicator@824000 { > > + compatible = "qcom,coresight-replicator", "arm,primecell"; > > Shouldn't it be "qcom,coresight-replicator1x" ? > True, I still wonder, why we have to have this compatible string? Drivers are probed by amba_id and "arm,primecell", after all. Thanks, Ivan