* [PATCH] genirq: devres: Fix testing return value of request_any_context_irq()
@ 2015-05-11 8:54 Axel Lin
0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2015-05-11 8:54 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Stephen Boyd, linux-kernel@vger.kernel.org
request_any_context_irq() returns a negative value on failure.
It returns either IRQC_IS_HARDIRQ or IRQC_IS_NESTED on success.
So fix testing return value of request_any_context_irq().
Fixes: 0668d3065128 ("genirq: Add devm_request_any_context_irq()")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
kernel/irq/devres.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/devres.c b/kernel/irq/devres.c
index d5d0f73..9da7d22 100644
--- a/kernel/irq/devres.c
+++ b/kernel/irq/devres.c
@@ -104,7 +104,7 @@ int devm_request_any_context_irq(struct device *dev, unsigned int irq,
return -ENOMEM;
rc = request_any_context_irq(irq, handler, irqflags, devname, dev_id);
- if (rc) {
+ if (rc < 0) {
devres_free(dr);
return rc;
}
--
2.1.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-05-11 8:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-11 8:54 [PATCH] genirq: devres: Fix testing return value of request_any_context_irq() Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox