public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: lee.jones@linaro.org
Cc: broonie@kernel.org, lgirdwood@gmail.com, sameo@linux.intel.com,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: [RESEND PATCH v3 01/10] mfd: arizona: Use devres to manage reset GPIO
Date: Mon, 11 May 2015 13:58:01 +0100	[thread overview]
Message-ID: <1431349090-24173-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1431349090-24173-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>

This also handily fixes a leak of the GPIO in arizona_dev_exit.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/arizona-core.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index aed43a5..915cc28 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -728,9 +728,9 @@ int arizona_dev_init(struct arizona *arizona)
 
 	if (arizona->pdata.reset) {
 		/* Start out with /RESET low to put the chip into reset */
-		ret = gpio_request_one(arizona->pdata.reset,
-				       GPIOF_DIR_OUT | GPIOF_INIT_LOW,
-				       "arizona /RESET");
+		ret = devm_gpio_request_one(arizona->dev, arizona->pdata.reset,
+					    GPIOF_DIR_OUT | GPIOF_INIT_LOW,
+					    "arizona /RESET");
 		if (ret != 0) {
 			dev_err(dev, "Failed to request /RESET: %d\n", ret);
 			goto err_dcvdd;
@@ -1046,10 +1046,8 @@ int arizona_dev_init(struct arizona *arizona)
 err_irq:
 	arizona_irq_exit(arizona);
 err_reset:
-	if (arizona->pdata.reset) {
+	if (arizona->pdata.reset)
 		gpio_set_value_cansleep(arizona->pdata.reset, 0);
-		gpio_free(arizona->pdata.reset);
-	}
 	regulator_disable(arizona->dcvdd);
 err_enable:
 	regulator_bulk_disable(arizona->num_core_supplies,
-- 
1.7.2.5


  reply	other threads:[~2015-05-11 13:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 12:58 [RESEND PATCH v3 00/10] wm5110 Boot Fixups Charles Keepax
2015-05-11 12:58 ` Charles Keepax [this message]
2015-05-13 12:20   ` [RESEND PATCH v3 01/10] mfd: arizona: Use devres to manage reset GPIO Lee Jones
2015-05-11 12:58 ` [RESEND PATCH v3 02/10] mfd: arizona: Factor out hard reset into helper functions Charles Keepax
2015-05-13 12:20   ` Lee Jones
2015-05-11 12:58 ` [RESEND PATCH v3 03/10] mfd: wm5102: Ensure we always boot the device fully Charles Keepax
2015-05-13 12:20   ` Lee Jones
2015-05-11 12:58 ` [RESEND PATCH v3 04/10] mfd: arizona: Fix formating/style issues in arizona_apply_hardware_patch Charles Keepax
2015-05-13 12:21   ` Lee Jones
2015-05-11 12:58 ` [RESEND PATCH v3 05/10] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch Charles Keepax
2015-05-13 12:21   ` Lee Jones
2015-05-11 12:58 ` [RESEND PATCH v3 06/10] mfd: wm5110: Add register patch required for low power sleep Charles Keepax
2015-05-13 12:21   ` Lee Jones
2015-05-11 12:58 ` [RESEND PATCH v3 07/10] regulator: arizona-ldo1: Add additional supported voltage Charles Keepax
2015-05-11 14:20   ` Mark Brown
2015-05-11 14:41     ` Charles Keepax
2015-05-11 16:04       ` Mark Brown
2015-05-11 12:58 ` [RESEND PATCH v3 08/10] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode Charles Keepax
2015-05-13 12:21   ` Lee Jones
2015-05-11 12:58 ` [RESEND PATCH v3 09/10] mfd: arizona: Add better support for system suspend Charles Keepax
2015-05-13 12:21   ` Lee Jones
2015-05-11 12:58 ` [RESEND PATCH v3 10/10] mfd: wm5110: Add delay before releasing reset line Charles Keepax
2015-05-13 12:22   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431349090-24173-2-git-send-email-ckeepax@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox