From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Borislav Petkov <bp@suse.de>,
Mark Rustad <mark.d.rustad@intel.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH v3 1/3] x86/setup: introduce setup_bultin_cmdline
Date: Tue, 12 May 2015 20:52:13 +0300 [thread overview]
Message-ID: <1431453133.28073.66.camel@linux.intel.com> (raw)
In-Reply-To: <CANCZXo7yH39OEt2nYN60mf5e3w+nbEa0337T+9hnAzjjrw99NQ@mail.gmail.com>
On Tue, 2015-05-12 at 22:14 +0600, Alexander Kuleshov wrote:
> Hi Andy,
>
>
> 2015-05-12 16:50 GMT+06:00 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> >
> > This one breaks kernel to work. You have to call setup_builtin_cmdline()
> > here.
> >
> >> strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
> >> *cmdline_p = command_line;
> >>
>
> Why? The setup_builtin_cmdline will be called before setup_arch in the
> head{32, 64}.c,
> or I've missed something?
Yes, you missed the call here in *this* patch.
So, here is a trade off between smaller understandable changes and
bisectability. On one hand you may go like you did previously (one patch
for two changes), on the other — make it work after each patch applied
one-by-one.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-05-12 17:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 10:08 [PATCH RESEND v5 0/2] x86/earlyprintk: setup earlyprintk as early as possible Alexander Kuleshov
2015-05-11 10:09 ` [PATCH v2 1/2] x86/setup: introduce setup_bultin_cmdline Alexander Kuleshov
2015-05-11 10:21 ` Borislav Petkov
2015-05-11 10:36 ` Andy Shevchenko
2015-05-11 10:09 ` [PATCH v5 2/2] x86/earlyprintk: setup earlyprintk as early as possible Alexander Kuleshov
2015-05-11 10:24 ` Borislav Petkov
2015-05-11 10:39 ` [PATCH RESEND v5 0/2] " Andy Shevchenko
2015-05-12 8:08 ` [PATCH v6 0/3] Alexander Kuleshov
2015-05-12 8:09 ` [PATCH v3 1/3] x86/setup: introduce setup_bultin_cmdline Alexander Kuleshov
2015-05-12 10:50 ` Andy Shevchenko
2015-05-12 16:14 ` Alexander Kuleshov
2015-05-12 17:52 ` Andy Shevchenko [this message]
2015-05-12 8:09 ` [PATCH v1 2/3] x86/setup: handle builtin command line as early as possible Alexander Kuleshov
2015-05-12 8:10 ` [PATCH v6 3/3] x86/earlyprintk: setup earlyprintk " Alexander Kuleshov
2015-05-12 11:19 ` Andy Shevchenko
2015-05-12 16:26 ` Alexander Kuleshov
2015-05-12 17:58 ` Andy Shevchenko
2015-05-12 18:08 ` Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431453133.28073.66.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox