From: Joe Perches <joe@perches.com>
To: Brian Norris <computersforpeace@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
Kevin Cernekee <cernekee@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: add brcmstb regex
Date: Tue, 12 May 2015 16:10:50 -0700 [thread overview]
Message-ID: <1431472250.2884.101.camel@perches.com> (raw)
In-Reply-To: <20150512230207.GB11598@ld-irv-0074>
(cc'ing Andrew Morton)
On Tue, 2015-05-12 at 16:02 -0700, Brian Norris wrote:
> On Wed, Mar 18, 2015 at 06:09:05PM -0700, Brian Norris wrote:
> > This could probably consolidate a few file listings. And it satisfies
> > the spirit of the highly annoying [1] checkpatch warning for every new
> > file, though it sadly won't quash it.
> >
> > [1] https://lkml.org/lkml/2014/12/17/24
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>
> Ping? Is this a good entry?
As you're a MAINTAINER of this section, if you want it to
be a good entry, it's a good entry.
You should get someone (Andrew?) to apply it.
Be aware that N: matches aren't as "owned" as F: matches.
Note from MAINTAINERS:
N: Files and directories with regex patterns.
One pattern per line. Multiple N: lines acceptable.
scripts/get_maintainer.pl has different behavior for files that
match F: pattern and matches of N: patterns. By default,
get_maintainer will not look at git log history when an F: pattern
match occurs. When an N: match occurs, git log history is used
to also notify the people that have git commit signatures.
> One problem is that there may be 'brcmstb' drivers for MIPS as well as
> ARM. But on that train of thought: there are several drivers which are
> already somewhat inaccurately-listed. The following are listed under
> either the BCM7XXX ARM subarchitecture or BMIPS MIPS subarchitecture,
> though they are actually used on both:
>
> drivers/bus/brcmstb_gisb.c
> drivers/irqchip/irq-brcmstb-l2.c
> drivers/irqchip/irq-bcm7120-l2.c
>
> Brian
>
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 0e1abe8cc684..52a1cf7cd18a 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2179,6 +2179,7 @@ S: Maintained
> > F: arch/arm/mach-bcm/*brcmstb*
> > F: arch/arm/boot/dts/bcm7*.dts*
> > F: drivers/bus/brcmstb_gisb.c
> > +N: brcmstb
> >
> > BROADCOM BMIPS MIPS ARCHITECTURE
> > M: Kevin Cernekee <cernekee@gmail.com>
> > --
> > 1.9.1
> >
next prev parent reply other threads:[~2015-05-12 23:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 1:09 [PATCH] MAINTAINERS: add brcmstb regex Brian Norris
2015-05-12 23:02 ` Brian Norris
2015-05-12 23:10 ` Joe Perches [this message]
2015-05-12 23:24 ` Brian Norris
2015-05-13 17:54 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431472250.2884.101.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox