From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933873AbbEMJ6a (ORCPT ); Wed, 13 May 2015 05:58:30 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:35109 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932707AbbEMJ61 (ORCPT ); Wed, 13 May 2015 05:58:27 -0400 Message-ID: <1431511102.2398.187.camel@x220> Subject: Re: [PATCH 1/1] OpenRISC: Fix kernel build problem on OpenRISC From: Paul Bolle To: Guenter Roeck Cc: anees , Jonas Bonn , linux@lists.openrisc.net, linux-kernel@vger.kernel.org Date: Wed, 13 May 2015 11:58:22 +0200 In-Reply-To: <20150512200743.GA6155@roeck-us.net> References: <1431438321-4697-1-git-send-email-rean12is@gmail.com> <20150512200743.GA6155@roeck-us.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-05-12 at 13:07 -0700, Guenter Roeck wrote: > On Tue, May 12, 2015 at 03:45:21PM +0200, anees wrote: > > Kernel build fails with error "target elf32-or32 not found" > > This is due to the change in OpenRISC compiler prefix from "or12" > > to "or1k". Add config options that set architecture output format > > default to "or1k" but also allow user to select older prefix. > > > > Tested with gcc version 4.9.1 uclibc > > > > Signed-off-by: anees > > --- > > arch/openrisc/Kconfig | 12 ++++++++++++ > > arch/openrisc/kernel/vmlinux.lds.S | 6 +++--- > > 2 files changed, 15 insertions(+), 3 deletions(-) > > > > diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig > > index e5a693b..c7fe7c8 100644 > > --- a/arch/openrisc/Kconfig > > +++ b/arch/openrisc/Kconfig > > @@ -75,6 +75,18 @@ config OPENRISC_BUILTIN_DTB > > string "Builtin DTB" > > default "" > > > > +config OUTPUT_FORMAT_TYPE > > + string "Architecture output format type" > > + default "or1k" > > + help > > + Write "or12" if building kernel against an older toolchain > > + else leave the default (or1k) > > + > That means I'll have to use different toolchains for different kernel > versions, or hand-edit default configuration files to able to work > with the same toolchain. Both is, from a testing perspective, > quite annoying. Also quite annoying would be $ grep OUTPUT_FORMAT .config CONFIG_OUTPUT_FORMAT_TYPE="typo" (Note the missing CONFIG_OUTPUT_FORMAT= line.) What might be less annoying would be something (completely untested) like: choice prompt "Architecture output format type" default OUTPUT_FORMAT_OR1K help Choose "or12" if building kernel against an older toolchain else leave the default "or1k". config OUTPUT_FORMAT_OR1K bool "or1k" config OUTPUT_FORMAT_OR12 bool "or12" enchoice config OUTPUT_FORMAT string default "elf32-or1k" if OUTPUT_FORMAT_OR1K default "elf32-or12" if OUTPUT_FORMAT_OR12 > Maybe I should simply stop testing older kernels for openrisc > after this patch has been merged; that would be much easier. > Jonas, is that ok with you ? Would testing be easier if you'd be provided with two defconfig files? Ie, one for "elf32-or1k" and "elf32-or12". (Note that "elf32-or12" smells like a typo to me. Shouldn't that be "elf32-or32"? If not, where does "elf32-or32" fir in this story?) > Side note: I didn't drop it from Cc:, but the openrisc.net domain > name expired and appears to be for sale. That's ominous. Thanks, Paul Bolle