From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753398AbbEPG4s (ORCPT ); Sat, 16 May 2015 02:56:48 -0400 Received: from smtprelay0151.hostedemail.com ([216.40.44.151]:54007 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752159AbbEPG4p (ORCPT ); Sat, 16 May 2015 02:56:45 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3870:3871:4250:4321:5007:6261:7807:7875:7903:10004:10400:10848:11026:11232:11657:11658:11914:12043:12296:12438:12517:12519:12555:12740:13019:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: side82_3a8071f978622 X-Filterd-Recvd-Size: 2209 Message-ID: <1431759401.15709.65.camel@perches.com> Subject: Re: [PATCH] Fixed coding style issues at ieee80211_crypt_wep.c From: Joe Perches To: Pedro Marzo Perez Cc: gregkh@linuxfoundation.org, navyasri.tech@gmail.com, dilekuzulmez@gmail.com, haticeerturk27@gmail.com, senija.stanojevic@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 15 May 2015 23:56:41 -0700 In-Reply-To: <1431765608-3658-1-git-send-email-marzo.pedro@gmail.com> References: <1431765608-3658-1-git-send-email-marzo.pedro@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-05-16 at 10:40 +0200, Pedro Marzo Perez wrote: > This patch just fixes some warnings and style errors reported by checkpatch.pl script > - Braces should not start in a new line > - C99 comments are not allowed (never use //) > - Literal strings should never be parted in several lines > - There was a useless return on a void function Some will say this is doing too many things in a single patch. > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c [] > + pr_debug("ieee80211_crypt_wep: could not allocate crypto API arc4\n"); [] > + pr_debug("ieee80211_crypt_wep: could not allocate crypto API arc4\n"); These could use a pr_fmt prefix and the "ieee80211_crypt_wep: " could be removed. In fact, these could be consolidated into a single line if moved into the fail block if the first allocation does a direct return NULL instead of goto fail. > @@ -293,6 +288,5 @@ void __exit ieee80211_crypto_wep_exit(void) > > void ieee80211_wep_null(void) > { > -// printk("============>%s()\n", __func__); > - return; > + /*printk("============>%s()\n", __func__);*/ Just delete this instead. > }