From: Fabio Estevam <festevam@gmail.com>
To: lee.jones@linaro.org
Cc: Julia.Lawall@lip6.fr, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag
Date: Sat, 16 May 2015 15:42:10 -0300 [thread overview]
Message-ID: <1431801737-9027-1-git-send-email-festevam@gmail.com> (raw)
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mfd/twl4030-irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 1b772ef..a3fa7f4 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -674,7 +674,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
irq_set_handler_data(irq, agent);
agent->irq_name = kasprintf(GFP_KERNEL, "twl4030_%s", sih->name);
status = request_threaded_irq(irq, NULL, handle_twl4030_sih,
- IRQF_EARLY_RESUME,
+ IRQF_EARLY_RESUME | IRQF_ONESHOT,
agent->irq_name ?: sih->name, NULL);
dev_info(dev, "%s (irq %d) chaining IRQs %d..%d\n", sih->name,
--
1.9.1
next reply other threads:[~2015-05-16 18:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 18:42 Fabio Estevam [this message]
2015-05-16 18:42 ` [PATCH 2/8] mfd: mc13xxx-core: Pass the IRQF_ONESHOT flag Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 3/8] mfd: wm831x-auxadc: " Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 4/8] mfd: htc-i2cpld: " Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 5/8] mfd: wm8350-core: " Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 6/8] mfd: ab8500-debugfs: " Fabio Estevam
2015-06-09 7:56 ` Lee Jones
2015-05-16 18:42 ` [PATCH 7/8] mfd: ab8500-gpadc: " Fabio Estevam
2015-06-09 7:56 ` Lee Jones
2015-05-16 18:42 ` [PATCH 8/8] mfd: si476x-i2c: " Fabio Estevam
2015-06-09 7:56 ` Lee Jones
2015-06-07 16:57 ` [PATCH 1/8] mfd: twl4030-irq: " Fabio Estevam
2015-06-09 7:54 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431801737-9027-1-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=fabio.estevam@freescale.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox