public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: lee.jones@linaro.org
Cc: Julia.Lawall@lip6.fr, linux-kernel@vger.kernel.org,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH 7/8] mfd: ab8500-gpadc: Pass the IRQF_ONESHOT flag
Date: Sat, 16 May 2015 15:42:16 -0300	[thread overview]
Message-ID: <1431801737-9027-7-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1431801737-9027-1-git-send-email-festevam@gmail.com>

From: Fabio Estevam <fabio.estevam@freescale.com>

Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/mfd/ab8500-gpadc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
index dabbc93..c51c1b1 100644
--- a/drivers/mfd/ab8500-gpadc.c
+++ b/drivers/mfd/ab8500-gpadc.c
@@ -948,7 +948,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
 	if (gpadc->irq_sw >= 0) {
 		ret = request_threaded_irq(gpadc->irq_sw, NULL,
 			ab8500_bm_gpadcconvend_handler,
-			IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-sw",
+			IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
+			"ab8500-gpadc-sw",
 			gpadc);
 		if (ret < 0) {
 			dev_err(gpadc->dev,
@@ -961,7 +962,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
 	if (gpadc->irq_hw >= 0) {
 		ret = request_threaded_irq(gpadc->irq_hw, NULL,
 			ab8500_bm_gpadcconvend_handler,
-			IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-hw",
+			IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
+			"ab8500-gpadc-hw",
 			gpadc);
 		if (ret < 0) {
 			dev_err(gpadc->dev,
-- 
1.9.1


  parent reply	other threads:[~2015-05-16 18:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
2015-05-16 18:42 ` [PATCH 2/8] mfd: mc13xxx-core: " Fabio Estevam
2015-06-09  7:55   ` Lee Jones
2015-05-16 18:42 ` [PATCH 3/8] mfd: wm831x-auxadc: " Fabio Estevam
2015-06-09  7:55   ` Lee Jones
2015-05-16 18:42 ` [PATCH 4/8] mfd: htc-i2cpld: " Fabio Estevam
2015-06-09  7:55   ` Lee Jones
2015-05-16 18:42 ` [PATCH 5/8] mfd: wm8350-core: " Fabio Estevam
2015-06-09  7:55   ` Lee Jones
2015-05-16 18:42 ` [PATCH 6/8] mfd: ab8500-debugfs: " Fabio Estevam
2015-06-09  7:56   ` Lee Jones
2015-05-16 18:42 ` Fabio Estevam [this message]
2015-06-09  7:56   ` [PATCH 7/8] mfd: ab8500-gpadc: " Lee Jones
2015-05-16 18:42 ` [PATCH 8/8] mfd: si476x-i2c: " Fabio Estevam
2015-06-09  7:56   ` Lee Jones
2015-06-07 16:57 ` [PATCH 1/8] mfd: twl4030-irq: " Fabio Estevam
2015-06-09  7:54 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431801737-9027-7-git-send-email-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=fabio.estevam@freescale.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox