From: Arthur Demchenkov <spinal.by@gmail.com>
To: abrestic@chromium.org
Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Arthur Demchenkov <spinal.by@gmail.com>
Subject: [PATCH] usb: make module xhci_hcd removable
Date: Mon, 18 May 2015 20:53:10 +0300 [thread overview]
Message-ID: <1431971590-4031-1-git-send-email-spinal.by@gmail.com> (raw)
Fixed regression. After commit 29e409f the module xhci_hcd became
non-removable. That behaviour is not expected and there're no notes
about it in commit message. The module should be removable as it
blocks PM suspend/resume functions (Debian Bug#666406).
Signed-off-by: Arthur Demchenkov <spinal.by@gmail.com>
---
drivers/usb/host/xhci.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index ec8ac16..4299cbf 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -5011,4 +5011,12 @@ static int __init xhci_hcd_init(void)
BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
return 0;
}
+
+/*
+ * If an init function is provided, an exit function must also be provided
+ * to allow module unload.
+ */
+static void __exit xhci_hcd_fini(void) { }
+
module_init(xhci_hcd_init);
+module_exit(xhci_hcd_fini);
--
2.3.6
next reply other threads:[~2015-05-18 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 17:53 Arthur Demchenkov [this message]
2015-05-18 20:07 ` [PATCH] usb: make module xhci_hcd removable Andrew Bresticker
2015-05-18 22:46 ` Greg KH
2015-05-19 5:24 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431971590-4031-1-git-send-email-spinal.by@gmail.com \
--to=spinal.by@gmail.com \
--cc=abrestic@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox