From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754648AbbERUEq (ORCPT ); Mon, 18 May 2015 16:04:46 -0400 Received: from smtprelay0087.hostedemail.com ([216.40.44.87]:47529 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754148AbbERUEn (ORCPT ); Mon, 18 May 2015 16:04:43 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:967:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4361:5007:6261:6691:7903:8985:9025:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12517:12519:12555:12679:12740:13160:13229:13255:14093:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: show62_45ddcb8608912 X-Filterd-Recvd-Size: 3125 Message-ID: <1431979479.2870.66.camel@perches.com> Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c From: Joe Perches To: pmarzo Cc: Dan Carpenter , gregkh@linuxfoundation.org, navyasri.tech@gmail.com, dilekuzulmez@gmail.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 18 May 2015 13:04:39 -0700 In-Reply-To: <1431986168.9328.22.camel@pedrito-laptop> References: <1431970583-14204-1-git-send-email-marzo.pedro@gmail.com> <20150518161531.GI22558@mwanda> <1431986168.9328.22.camel@pedrito-laptop> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-05-18 at 23:56 +0200, pmarzo wrote: > On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote: > > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > > > Merge two pr_debug lines with literal strings splitted across several lines > > > into one single line, simplifying prism2_wep_init error check code. > > > Openning braces should never be in a new line, move them to the end of > > > the previous line. > > > Removed two useless lines at ieee80211_wep_null. > > > > > > > When Joe said "Some will say this is doing too many things in a single > > patch." he meant Greg. Break this up into multiple patches. Especially > > now that you've added even more stuff to it. > > > > regards, > > dan carpenter > > Sorry Joe, English is not my mother tongue and I misunderstand your > comment, I thought "Some will say this is doing too many things in a > single patch" did meant "You are on the limit, but it is ok to send it > in one patch" but I see it really means "please, rewrite this whole crap > into several patches" :-) What I meant to say was I don't care as much about mixing multiple types of fixes in a single patch as others might. Greg does and generally rejects patches that mix fix types. My preference is to do _all_ whitespace changes in a single patch. If "git diff -w" shows no source code changes, and objdiff shows no object code change, that's a "single type" of change to me. Others disagree and may want whitespace changes broken down into finer-grained blocks. I think it's not necessary to modify the same line multiple times just to get this granularity. btw: using: $ ./scripts/checkpatch.pl -f --strict --fix-inplace \ --types=spacing,space_before_tab,pointer_location,trailing_whitespace,bracket_space,space_before_tab,indented_label,parenthesis_alignment \ $file can do this moderately well and there's a trivial script to use checkpatch and git to create a patch series for various checkpatch type style messages. https://lkml.org/lkml/2014/7/11/794