public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: lee.jones@linaro.org
Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: [PATCH v2] mfd: arizona: Add missing braces
Date: Tue, 19 May 2015 16:22:11 +0100	[thread overview]
Message-ID: <1432048931-2287-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)

Some braces were missing from commit 67f0b1133d55 ("mfd: arizona:
Add better support for system suspend"). This will cause the error check
to run even if the register write didn't happen (although ret will
always be zero so it is harmless). This patch adds the missing
braces.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---

Changes since v1:
 - Corrected braino in commit message (parenthesis -> braces)

Thanks,
Charles

 drivers/mfd/arizona-core.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 5caf579..bebf58a 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -626,7 +626,7 @@ static int arizona_runtime_suspend(struct device *dev)
 		}
 		break;
 	case WM5102:
-		if (!(val & ARIZONA_JD1_ENA))
+		if (!(val & ARIZONA_JD1_ENA)) {
 			ret = regmap_write(arizona->regmap,
 					   ARIZONA_WRITE_SEQUENCER_CTRL_3, 0x0);
 			if (ret) {
@@ -635,6 +635,7 @@ static int arizona_runtime_suspend(struct device *dev)
 					ret);
 				return ret;
 			}
+		}
 		break;
 	default:
 		break;
-- 
1.7.2.5


             reply	other threads:[~2015-05-19 15:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 15:22 Charles Keepax [this message]
2015-05-26 13:56 ` [PATCH v2] mfd: arizona: Add missing braces Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432048931-2287-1-git-send-email-ckeepax@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=dan.carpenter@oracle.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox