From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbbESTZo (ORCPT ); Tue, 19 May 2015 15:25:44 -0400 Received: from smtprelay0027.hostedemail.com ([216.40.44.27]:42270 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750765AbbESTZl (ORCPT ); Tue, 19 May 2015 15:25:41 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:4321:4605:5007:6261:10004:10400:10848:11026:11232:11658:11914:12050:12296:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: toys11_4e73f13f8b242 X-Filterd-Recvd-Size: 1973 Message-ID: <1432063537.2870.203.camel@perches.com> Subject: Re: [PATCH] [RESEND] SCSI: ips: remove pointless #warning From: Joe Perches To: James Bottomley Cc: Arnd Bergmann , linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 19 May 2015 12:25:37 -0700 In-Reply-To: <1432060697.14737.1.camel@HansenPartnership.com> References: <3121960.dnOqT9LCth@wuerfel> <1432043572.3007.14.camel@HansenPartnership.com> <2850783.725LtIIUFq@wuerfel> <1432060697.14737.1.camel@HansenPartnership.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-05-19 at 11:38 -0700, James Bottomley wrote: > On Tue, 2015-05-19 at 15:56 +0200, Arnd Bergmann wrote: > > On Tuesday 19 May 2015 06:52:52 James Bottomley wrote: > > > On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote: > > > > The ips driver contains > > > > #warning "This driver has only been tested on the x86/ia64/x86_64 platforms" trivial: > > My main interest here is to get a clean build of ARM 'allmodconfig'. [] > What about this? It captures the intent of the > original but gets rid of the warning. [] > diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c [] > @@ -6788,6 +6784,11 @@ ips_remove_device(struct pci_dev *pci_dev) > static int __init > ips_module_init(void) > { > +#if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__) > + printk(KERN_ERR, "ips: This driver has only been tested on the x86/ia64/x86_64 platforms\n"); Bad comma after KERN_ERR, and KERN_ALERT might be better.