From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751543AbbESUjM (ORCPT ); Tue, 19 May 2015 16:39:12 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:33258 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbbESUjK (ORCPT ); Tue, 19 May 2015 16:39:10 -0400 Message-ID: <1432075769.20560.4.camel@pedrito-laptop> Subject: Re: [PATCH 1/3 v3] Staging: rtl8192u: Simplify error check code at prism2_wep_init From: pmarzo To: Sudip Mukherjee Cc: gregkh@linuxfoundation.org, navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Date: Wed, 20 May 2015 00:49:29 +0200 In-Reply-To: <20150519053419.GC3820@sudip-PC> References: <1431991944-16924-1-git-send-email-marzo.pedro@gmail.com> <1431991944-16924-2-git-send-email-marzo.pedro@gmail.com> <20150519053419.GC3820@sudip-PC> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-05-19 at 11:04 +0530, Sudip Mukherjee wrote: > On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote: > > Merge two pr_debug lines with literal strings splitted across several lines > > into one single line, simplifying prism2_wep_init error check code. > > I would have split this patch into three. > 1) introduce pr_fmt and remove "ieee80211_crypt_wep" from pr_debug > 2) return NULL instead of that goto fail. > 3) combine two pr_debug into a single at the fail block. > I firmly agree with the "one logical change-one patch" rule but this seems to me a bit overkilling.Anyway I am a completely newbie sending kernel patches so you are probably right. > But Dan can say if its ok. (I am still taking ideas from Dan about my > patches) Sure. Dan, we need your wisdom! > > regards > sudip thanku for your comments sudip! regards pedro > > > > Signed-off-by: Pedro Marzo Perez