public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Michal Hocko <mhocko@suse.cz>,
	Vladimir Davydov <vdavydov@parallels.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Bertrand Jacquin <beber@meleeweb.net>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Iulia Manda <iulia.manda21@gmail.com>,
	Pranith Kumar <bobby.prani@gmail.com>,
	Clark Williams <clark.williams@gmail.com>,
	Mel Gorman <mgorman@suse.de>,
	Randy Dunlap <rdunlap@infradead.org>,
	Michal Marek <mmarek@suse.cz>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] kconfig: Introduce "showif" to factor out conditions on visibility
Date: Wed, 20 May 2015 12:00:13 +0200	[thread overview]
Message-ID: <1432116013.21715.82.camel@x220> (raw)
In-Reply-To: <760264ebf529ba3b0aa007144e2862bc73807dad.1431589089.git.josh@joshtriplett.org>

Hi Josh,

On Thu, 2015-05-14 at 08:36 -0700, Josh Triplett wrote:
> kconfig implicitly creates a submenu whenever a series of symbols all
> have dependencies or prompt-visibility expressions that all depend on a
> preceeding symbol.  For instance, the series of symbols following
> "menuconfig EXPERT" that all have "if EXPERT" on their prompt will all
> appear as a submenu of EXPERT.
> 
> However, this implicit submenuing will break if any intervening symbol
> loses its "if EXPERT"; doing so causes the subsequent symbols to appear
> in the parent menu ("General setup").  This has happened many times, and
> it's easy to miss that the entire block should have that same
> expression.
> 
> For submenus created from "depends" dependencies, these can be converted
> to a single wrapping "if expr ... endif" block around all the submenu
> items.  However, there's no equivalent for invisible items, for which
> the prompt is hidden but the symbol may potentially be enabled.  For
> instance, many items in the EXPERT menu are hidden if EXPERT is
> disabled, but they have "default y" or are determined by some other
> expression.

No one has reacted so far. So my plan to have the other people on
linux-kbuild do the work here is not going as I'd hoped. Bother...

I seem to remember that you had a list of three dozen menuconfig
instances that ran into the same issue as EXPERT's menuconfig. Do you
still have that list at hand?

Thanks,


Paul Bolle


  reply	other threads:[~2015-05-20 10:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 15:35 [PATCH 1/5] init/Kconfig: Fix break in middle of EXPERT menu Josh Triplett
2015-05-14 15:35 ` [PATCH 2/5] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert Josh Triplett
2015-05-28  9:24   ` Paul Bolle
2015-05-14 15:35 ` [PATCH 3/5] kconfig: Regenerate parser with current Bison prior to making changes Josh Triplett
2015-05-28  9:34   ` Paul Bolle
2015-05-14 15:36 ` [PATCH 4/5] kconfig: Introduce "showif" to factor out conditions on visibility Josh Triplett
2015-05-20 10:00   ` Paul Bolle [this message]
2015-05-20 18:30     ` josh
2015-05-28 14:57       ` Paul Bolle
2015-05-28 18:28       ` Paul Bolle
2015-05-28 18:17   ` Paul Bolle
2015-05-28 18:23     ` Paul Bolle
2015-05-14 15:36 ` [PATCH 5/5] init/Kconfig.expert: Factor out "if EXPERT" conditions using showif Josh Triplett
2015-05-14 15:46 ` [PATCH 1/5] init/Kconfig: Fix break in middle of EXPERT menu josh
2015-05-28  8:41 ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432116013.21715.82.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=akpm@linux-foundation.org \
    --cc=beber@meleeweb.net \
    --cc=bobby.prani@gmail.com \
    --cc=clark.williams@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=hannes@cmpxchg.org \
    --cc=iulia.manda21@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mcgrof@suse.com \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=mingo@kernel.org \
    --cc=mmarek@suse.cz \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rdunlap@infradead.org \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox