From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Tim Waugh <tim@cyberelk.net>, Jean Delvare <jdelvare@suse.de>,
Wolfram Sang <wsa@the-dreams.de>,
Willy Tarreau <willy@meta-x.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
devel@driverdev.osuosl.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 2/6] staging: panel: use new parport device model
Date: Wed, 20 May 2015 20:56:58 +0530 [thread overview]
Message-ID: <1432135622-8288-3-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1432135622-8288-1-git-send-email-sudipm.mukherjee@gmail.com>
Converted to use the new device-model parallel port.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
The comment about panel_cb.flags can be removed, it is kept just
for the comment to remind us that it might be better to use
PARPORT_DEV_EXCL.
drivers/staging/panel/panel.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 1d8ed8b..70f0ac6 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -2190,6 +2190,8 @@ static struct notifier_block panel_notifier = {
static void panel_attach(struct parport *port)
{
+ struct pardev_cb panel_cb;
+
if (port->number != parport)
return;
@@ -2199,10 +2201,11 @@ static void panel_attach(struct parport *port)
return;
}
- pprt = parport_register_device(port, "panel", NULL, NULL, /* pf, kf */
- NULL,
- /*PARPORT_DEV_EXCL */
- 0, (void *)&pprt);
+ memset(&panel_cb, 0, sizeof(panel_cb));
+ panel_cb.private = &pprt;
+ /* panel_cb.flags = 0 should be PARPORT_DEV_EXCL? */
+
+ pprt = parport_register_dev_model(port, "panel", &panel_cb, 0);
if (pprt == NULL) {
pr_err("%s: port->number=%d parport=%d, parport_register_device() failed\n",
__func__, port->number, parport);
@@ -2256,8 +2259,9 @@ static void panel_detach(struct parport *port)
static struct parport_driver panel_driver = {
.name = "panel",
- .attach = panel_attach,
+ .match_port = panel_attach,
.detach = panel_detach,
+ .devmodel = true,
};
/* init function */
--
1.8.1.2
next prev parent reply other threads:[~2015-05-20 15:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:26 [PATCH 0/6] use devicemodel with parport Sudip Mukherjee
2015-05-20 15:26 ` [PATCH 1/6] parport: add device-model to parport subsystem Sudip Mukherjee
2015-05-20 15:26 ` Sudip Mukherjee [this message]
2015-05-20 15:26 ` [PATCH 3/6] i2c-parport: define ports to connect Sudip Mukherjee
2015-05-20 15:46 ` Wolfram Sang
2015-05-20 15:27 ` [PATCH 4/6] i2c-parport: use new parport device model Sudip Mukherjee
2015-05-20 15:49 ` Wolfram Sang
2015-05-20 17:14 ` Sudip Mukherjee
2015-05-20 17:35 ` Wolfram Sang
2015-05-20 17:59 ` Jean Delvare
2015-05-21 1:02 ` [RFC PATCH] checkpatch: check for 2 or more spaces around assignment of a declaration Joe Perches
2015-05-21 5:48 ` Willy Tarreau
2015-05-21 6:16 ` [PATCH v2 4/6] i2c-parport: use new parport device model Sudip Mukherjee
2015-05-20 15:27 ` [PATCH 5/6] paride: " Sudip Mukherjee
2015-05-20 15:27 ` [PATCH 6/6] MAINTAINERS: maintain parport Sudip Mukherjee
2015-05-20 15:46 ` Richard Weinberger
2015-05-20 16:28 ` Joe Perches
2015-05-20 17:31 ` Sudip Mukherjee
2015-05-20 16:33 ` One Thousand Gnomes
2015-05-20 20:36 ` Richard Weinberger
2015-05-21 5:59 ` Sudip Mukherjee
2015-05-21 5:51 ` Willy Tarreau
2015-05-21 6:09 ` Greg Kroah-Hartman
2015-05-31 22:05 ` [PATCH 0/6] use devicemodel with parport Greg Kroah-Hartman
2015-06-01 5:46 ` Sudip Mukherjee
2015-06-01 6:18 ` Greg Kroah-Hartman
2015-06-01 8:34 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432135622-8288-3-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@cyberelk.net \
--cc=willy@meta-x.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).