public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
	Johannes Thumshirn <jtumshirn@suse.com>,
	Hannes Reinecke <hare@suse.de>, Paul Bolle <pebolle@tiscali.nl>
Subject: [PATCHv2] edd: support original Phoenix EDD 3.0 information
Date: Thu, 21 May 2015 09:39:44 +0200	[thread overview]
Message-ID: <1432193984-64021-1-git-send-email-hare@suse.de> (raw)

The original Phoenix EDD 3.0 specification (as found in
eg http://mbldr.sourceforge.net/specsedd30.pdf) has a
device path length of 36, not 44.
All the other fields are identical, so we can trivially support
both formats.

Cc: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/firmware/edd.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index e229576..92bc0e8 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -8,6 +8,8 @@
  * BIOS Enhanced Disk Drive Services (EDD)
  * conformant to T13 Committee www.t13.org
  *   projects 1572D, 1484D, 1386D, 1226DT
+ * and the original Phoenix BIOS EDD 3.0 spec from
+ * <http://mbldr.sourceforge.net/specsedd30.pdf>
  *
  * This code takes information provided by BIOS EDD calls
  * fn41 - Check Extensions Present and
@@ -545,8 +547,9 @@ edd_has_edd30(struct edd_device *edev)
 	}
 
 
-	/* We support only T13 spec */
-	if (info->params.device_path_info_length != 44)
+	/* We support T13 d1572 and the original Phoenix spec */
+	if (info->params.device_path_info_length != 44 &&
+	    info->params.device_path_info_lenght != 36)
 		return 0;
 
 	for (i = 30; i < info->params.device_path_info_length + 30; i++)
-- 
1.8.5.2


             reply	other threads:[~2015-05-21  7:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21  7:39 Hannes Reinecke [this message]
2015-05-21  7:40 ` [PATCHv2] edd: support original Phoenix EDD 3.0 information Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432193984-64021-1-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc=hpa@linux.intel.com \
    --cc=jtumshirn@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox