Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

Felipe Balbi
2015-07-06T17:07:51Z

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

On Wed, Jul 01, 2015 at 07:29:28AM +0000, Subbaraya Sundeep Bhatta wrote:
> Hi Felipe,
>
> > -----Original Message-----
> > From: Felipe Balbi [mailto:balbi@ti.com]
> > Sent: Tuesday, June 30, 2015 3:17 AM
> > To: Subbaraya Sundeep Bhatta
> > Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org;
> > linux-kernel@vger.kernel.org; stable@vger.kernel.org; Subbaraya Sundeep
> > Bhatta
> > Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command
> > sent to DEPCMD register fails
> >
> > Hi,
> >
> > On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta
> > wrote:
> > > We need to return error to caller if command is not sent to controller
> > > succesfully.
> > >
> > > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
> > > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
> > > Cc: <stable@vger.kernel.org>
> > > ---
> > > v2 changes:
> > > Added Fixes and Cc in commit message.
> >
> > I noticed that this breaks at least my AM437x silicon with DWC3 2.40a
> > when used with g_zero and testusb. As of now, it could be that silicon is
> > mis-behaving because I got a Transfer Complete before the failing Set
> > Endpoint Transfer Resource command.
> >
> > In any case, can you run on your setup with g_zero and test.sh/testusb
> > [1]/[2] just to verify that it really works for you ?
>
> Ok I will do that.

Did you manage to run the test I asked ? If we don't get down to this,
I'll have to revert your patch as it regresses my platforms.

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]