Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

Felipe Balbi
2015-07-07T03:25:01Z

[-- Attachment #1: Type: text/plain, Size: 3076 bytes --]

Hi,

On Tue, Jul 07, 2015 at 02:10:26AM +0000, John Youn wrote:
> On 7/1/2015 8:00 PM, Felipe Balbi wrote:
> > On Thu, Jul 02, 2015 at 02:03:14AM +0000, John Youn wrote:
> >> On 6/29/2015 2:48 PM, Felipe Balbi wrote:
> >>> Hi again,
> >>>
> >>> On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote:
> >>>> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
> >>>>> We need to return error to caller if command is not sent to
> >>>>> controller succesfully.
> >>>>>
> >>>>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
> >>>>> Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
> >>>>> Cc: <stable@vger.kernel.org>
> >>>>> ---
> >>>>> v2 changes:
> >>>>> Added Fixes and Cc in commit message.
> >>>>
> >>>> I noticed that this breaks at least my AM437x silicon with DWC3 2.40a
> >>>> when used with g_zero and testusb. As of now, it could be that silicon
> >>>> is mis-behaving because I got a Transfer Complete before the failing Set
> >>>> Endpoint Transfer Resource command.
> >>>>
> >>>> In any case, can you run on your setup with g_zero and test.sh/testusb
> >>>> [1]/[2] just to verify that it really works for you ?
> >>>>
> >>>> Meanwhile, I'll continue testing on my end.
> >>>>
> >>>> cheers
> >>>>
> >>>> [1] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:testusb.c
> >>>> [2] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:test.sh
> >>>
> >>> Adding John here. John, any chance you could fire up dwc3 on HAPS and
> >>> see wether it works or fails for you ?
> >>>
> >>> cheers
> >>>
> >>
> >> Hi Felipe,
> >>
> >> Just an update on this.
> >>
> >> I'm trying to get this working with our latest IP with dwc3 from your
> >> testing/next branch. It fails the usbtest with a problem unrelated to
> >> this patch.
> >>
> >> It passes on 4.1.1.
> >>
> >> I'll have to look into the failure but I won't get to it until next
> >> week as I'm off the rest of this week.
> >
> > interesting... If you could post failure signature, I can help looking
> > at it, but I guess it's too late to ask :-)
> >
> > thanks for helping though
> >
>
>
> Hi Felipe,
>
> Nevermind about my issue, it ended up being a setup-related
> problem.
>
> I actually do see the same error as you due to this series of
> patches. Except I see it happening before even the first
> iteration. I get a completion status of 1 for the Set Endpoint
> Transfer Resources command. I'm not sure why this is.
>
> I don't see any conflict with any previous Transfer Complete.
>
> I will have to consult with some hardware engineers tomorrow to
> look into it further.

cool, thanks. Just let me know if it ends up being something larger,
then we can revert that commit for the time being until we come to a
conclusion. Thanks a lot for helping with testing.

> The trace is attached.

thanks a lot :-) Do you mind letting me know which version are you
using? 3.00a ?

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]