RE: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

Subbaraya Sundeep Bhatta
2015-07-08T09:51:02Z

Hi Felipe,

> -----Original Message-----
> From: Subbaraya Sundeep Bhatta
> Sent: Tuesday, July 07, 2015 10:32 AM
> To: 'balbi@ti.com'
> Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org; stable@vger.kernel.org
> Subject: RE: [PATCH v2 3/3] usb: dwc3: gadget: return error if command
> sent to DEPCMD register fails
>
> Hi Felipe,
>
> > -----Original Message-----
> > From: Felipe Balbi [mailto:balbi@ti.com]
> > Sent: Monday, July 06, 2015 10:38 PM
> > To: Subbaraya Sundeep Bhatta
> > Cc: balbi@ti.com; gregkh@linuxfoundation.org;
> > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
> > stable@vger.kernel.org
> > Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command
> > sent to DEPCMD register fails
> >
> > On Wed, Jul 01, 2015 at 07:29:28AM +0000, Subbaraya Sundeep Bhatta
> > wrote:
> > > Hi Felipe,
> > >
> > > > -----Original Message-----
> > > > From: Felipe Balbi [mailto:balbi@ti.com]
> > > > Sent: Tuesday, June 30, 2015 3:17 AM
> > > > To: Subbaraya Sundeep Bhatta
> > > > Cc: balbi@ti.com; gregkh@linuxfoundation.org;
> > > > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > > stable@vger.kernel.org; Subbaraya Sundeep Bhatta
> > > > Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if
> > > > command sent to DEPCMD register fails
> > > >
> > > > Hi,
> > > >
> > > > On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep
> > Bhatta
> > > > wrote:
> > > > > We need to return error to caller if command is not sent to
> > > > > controller succesfully.
> > > > >
> > > > > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
> > > > > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
> > > > > Cc: <stable@vger.kernel.org>
> > > > > ---
> > > > > v2 changes:
> > > > > Added Fixes and Cc in commit message.
> > > >
> > > > I noticed that this breaks at least my AM437x silicon with DWC3
> > > > 2.40a when used with g_zero and testusb. As of now, it could be
> > > > that silicon is mis-behaving because I got a Transfer Complete
> > > > before the failing Set Endpoint Transfer Resource command.
> > > >
> > > > In any case, can you run on your setup with g_zero and
> > > > test.sh/testusb [1]/[2] just to verify that it really works for you ?

Can you please send test.sh and testusb.c in attachment. I guess am not able to access gitorious because of its migration.

Thanks,
Sundeep

> > >
> > > Ok I will do that.
> >
> > Did you manage to run the test I asked ? If we don't get down to this,
> > I'll have to revert your patch as it regresses my platforms.
>
> Sorry I caught up with some other customer reported issue on Zynq
> (Chipidea). I will do it by this weekend at any cost. Please wait.
>
> Thanks,
> Sundeep.B.S.
>
> >
> > --
> > balbi

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.