* [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID
@ 2015-05-20 15:02 Ivan T. Ivanov
2015-05-21 14:10 ` Mathieu Poirier
0 siblings, 1 reply; 4+ messages in thread
From: Ivan T. Ivanov @ 2015-05-20 15:02 UTC (permalink / raw)
To: Mathieu Poirier; +Cc: linux-arm-kernel, linux-kernel, linux-arm-msm
Add Qualcomm's PFT v1.1 peripheral ID to supported devices.
This device could be found at least in MSM8974 and APQ8064
chipsets.
Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
---
drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
index 018a00f..e13520f 100644
--- a/drivers/hwtracing/coresight/coresight-etm3x.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x.c
@@ -1912,6 +1912,11 @@ static struct amba_id etm_ids[] = {
.mask = 0x0003ffff,
.data = "PTM 1.1",
},
+ { /* PFT 1.1 Qualcomm */
+ .id = 0x0003006f,
+ .mask = 0x0003ffff,
+ .data = "PFT 1.1",
+ },
{ 0, 0},
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID
2015-05-20 15:02 [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID Ivan T. Ivanov
@ 2015-05-21 14:10 ` Mathieu Poirier
2015-05-21 15:24 ` Ivan T. Ivanov
0 siblings, 1 reply; 4+ messages in thread
From: Mathieu Poirier @ 2015-05-21 14:10 UTC (permalink / raw)
To: Ivan T. Ivanov
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm
On 20 May 2015 at 09:02, Ivan T. Ivanov <ivan.ivanov@linaro.org> wrote:
> Add Qualcomm's PFT v1.1 peripheral ID to supported devices.
> This device could be found at least in MSM8974 and APQ8064
> chipsets.
>
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
> index 018a00f..e13520f 100644
> --- a/drivers/hwtracing/coresight/coresight-etm3x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
> @@ -1912,6 +1912,11 @@ static struct amba_id etm_ids[] = {
> .mask = 0x0003ffff,
> .data = "PTM 1.1",
> },
> + { /* PFT 1.1 Qualcomm */
> + .id = 0x0003006f,
> + .mask = 0x0003ffff,
> + .data = "PFT 1.1",
> + },
> { 0, 0},
> };
I'm essentially good with that. On the flip side "PFT" is the format
of the output generated by the tracer. What is important to identify
is the type of tracer fitted to the SoC, either "ETM" or "PTM".
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID
2015-05-21 14:10 ` Mathieu Poirier
@ 2015-05-21 15:24 ` Ivan T. Ivanov
2015-05-22 13:57 ` Mathieu Poirier
0 siblings, 1 reply; 4+ messages in thread
From: Ivan T. Ivanov @ 2015-05-21 15:24 UTC (permalink / raw)
To: Mathieu Poirier
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm
On Thu, 2015-05-21 at 08:10 -0600, Mathieu Poirier wrote:
> On 20 May 2015 at 09:02, Ivan T. Ivanov ivanov@linaro.org> wrote:
> > Add Qualcomm's PFT v1.1 peripheral ID to supported devices.
> > This device could be found at least in MSM8974 and APQ8064
> > chipsets.
> >
> > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org>
> > ---
> > drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c
> > b/drivers/hwtracing/coresight/coresight-etm3x.c
> > index 018a00f..e13520f 100644
> > --- a/drivers/hwtracing/coresight/coresight-etm3x.c
> > +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
> > @@ -1912,6 +1912,11 @@ static struct amba_id etm_ids[] = {
> > .mask = 0x0003ffff,
> > .data = "PTM 1.1",
> > },
> > + { /* PFT 1.1 Qualcomm */
> > + .id = 0x0003006f,
> > + .mask = 0x0003ffff,
> > + .data = "PFT 1.1",
> > + },
> > { 0, 0},
> > };
>
> I'm essentially good with that. On the flip side "PFT" is the format
> of the output generated by the tracer. What is important to identify
> is the type of tracer fitted to the SoC, either "ETM" or "PTM".
I was unable to find PTM 1.1 in the ARM documentation and PFT
v1.1 is supported only by PTM, if understand it correctly.
Regards,
Ivan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID
2015-05-21 15:24 ` Ivan T. Ivanov
@ 2015-05-22 13:57 ` Mathieu Poirier
0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2015-05-22 13:57 UTC (permalink / raw)
To: Ivan T. Ivanov
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm
On 21 May 2015 at 09:24, Ivan T. Ivanov <ivan.ivanov@linaro.org> wrote:
>
> On Thu, 2015-05-21 at 08:10 -0600, Mathieu Poirier wrote:
>> On 20 May 2015 at 09:02, Ivan T. Ivanov ivanov@linaro.org> wrote:
>> > Add Qualcomm's PFT v1.1 peripheral ID to supported devices.
>> > This device could be found at least in MSM8974 and APQ8064
>> > chipsets.
>> >
>> > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org>
>> > ---
>> > drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
>> > 1 file changed, 5 insertions(+)
>> >
>> > diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c
>> > b/drivers/hwtracing/coresight/coresight-etm3x.c
>> > index 018a00f..e13520f 100644
>> > --- a/drivers/hwtracing/coresight/coresight-etm3x.c
>> > +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
>> > @@ -1912,6 +1912,11 @@ static struct amba_id etm_ids[] = {
>> > .mask = 0x0003ffff,
>> > .data = "PTM 1.1",
>> > },
>> > + { /* PFT 1.1 Qualcomm */
>> > + .id = 0x0003006f,
>> > + .mask = 0x0003ffff,
>> > + .data = "PFT 1.1",
>> > + },
>> > { 0, 0},
>> > };
>>
>> I'm essentially good with that. On the flip side "PFT" is the format
>> of the output generated by the tracer. What is important to identify
>> is the type of tracer fitted to the SoC, either "ETM" or "PTM".
>
> I was unable to find PTM 1.1 in the ARM documentation and PFT
> v1.1 is supported only by PTM, if understand it correctly.
>
> Regards,
> Ivan
It does not change anything - PFT is the protocol and PTM is the tracer.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-22 13:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-20 15:02 [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID Ivan T. Ivanov
2015-05-21 14:10 ` Mathieu Poirier
2015-05-21 15:24 ` Ivan T. Ivanov
2015-05-22 13:57 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox