From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964798AbbEVEhH (ORCPT ); Fri, 22 May 2015 00:37:07 -0400 Received: from smtprelay0148.hostedemail.com ([216.40.44.148]:58875 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750912AbbEVEhE (ORCPT ); Fri, 22 May 2015 00:37:04 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 10,1,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1406:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:1894:2189:2393:2559:2562:2828:2895:2904:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3872:4321:5007:6261:6742:6743:7875:10004:10400:10848:11026:11658:11914:12438:12517:12519:12555:12740:13069:13071:13255:13311:13357:13548:14346:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: copy04_3d1c2b639d225 X-Filterd-Recvd-Size: 2234 Message-ID: <1432269418.29657.5.camel@perches.com> Subject: Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. From: Joe Perches To: Kevin Tsai Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Andrew Morton , Greg KH , "David S. Miller" , Mauro Carvalho Chehab , Arnd Bergmann , Jingoo Han , Daniel Baluta , Roberta Dobrescu , Kuppuswamy Sathyanarayanan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Date: Thu, 21 May 2015 21:36:58 -0700 In-Reply-To: <1432268380-7302-1-git-send-email-ktsai@capellamicro.com> References: <1432268380-7302-1-git-send-email-ktsai@capellamicro.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-05-21 at 21:19 -0700, Kevin Tsai wrote: > - Renamed company name. > - Removed cm32181_reg. > - Removed white space. > - Removed unused include files. > - Updated macro definitions. > - Renamed cm32181_chip pointer to chip. Hi Kevin, Please don't use the same title for multiple patches. It'd be better if these 6 patches were titled something like 1/6 cm32181: Neatening 2/6 cm32181: Add cm32181_als_info 3/6: cm32181: Add power management support 4/6: cm32181: Add and use cm32181_als_it_scale 5/6: cm32181: Add device tree support 6/6: cm32181: Add interrupt suppor It's