From: Paul Bolle <pebolle@tiscali.nl>
To: Ray Jui <rjui@broadcom.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org,
"JD (Jiandong) Zheng" <jdzheng@broadcom.com>,
Arun Parameswaran <arunp@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 4/5] phy: cygnus: pcie: Add Cygnus PCIe PHY support
Date: Fri, 22 May 2015 10:47:39 +0200 [thread overview]
Message-ID: <1432284459.27695.41.camel@x220> (raw)
In-Reply-To: <555E6FFC.2080309@broadcom.com>
On Thu, 2015-05-21 at 16:53 -0700, Ray Jui wrote:
> Yes, I'll change the PCIe PHY driver to tristate in the Kconfig. Thanks!
To continue the discussion started in 2/5: this is my main beef with
built-in only code using module specific macros. It forces the reader of
the patch, and the code if it's already in the tree, to know the
intentions of the author. Did the author intend the code to be built-in
only or not?
And since most people appear not to be clairvoyant that's kind of hard
to do for most of us.
Paul Bolle
next prev parent reply other threads:[~2015-05-22 8:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 1:23 [PATCH 0/5] Add Cygnus PCIe PHY support Ray Jui
2015-05-20 1:23 ` [PATCH 1/5] phy: iproc-mdio: Define DT binding Ray Jui
2015-05-21 13:07 ` Kishon Vijay Abraham I
2015-05-21 21:29 ` Ray Jui
2015-05-20 1:23 ` [PATCH 2/5] phy: iproc-mdio: Initial iProc MDC/MDIO support Ray Jui
2015-05-21 7:41 ` Paul Bolle
2015-05-21 23:52 ` Ray Jui
2015-05-22 8:39 ` Paul Bolle
2015-05-21 13:12 ` Kishon Vijay Abraham I
2015-05-21 21:35 ` Ray Jui
2015-05-21 21:51 ` Florian Fainelli
2015-05-21 22:02 ` Ray Jui
2015-05-20 1:23 ` [PATCH 3/5] phy: cygnus: pcie: Define DT binding Ray Jui
2015-05-21 13:14 ` Kishon Vijay Abraham I
2015-05-21 21:59 ` Ray Jui
2015-05-21 23:36 ` Ray Jui
2015-05-20 1:23 ` [PATCH 4/5] phy: cygnus: pcie: Add Cygnus PCIe PHY support Ray Jui
2015-05-21 7:52 ` Paul Bolle
2015-05-21 23:53 ` Ray Jui
2015-05-22 8:47 ` Paul Bolle [this message]
2015-05-21 13:19 ` Kishon Vijay Abraham I
2015-05-20 1:23 ` [PATCH 5/5] ARM: dts: enable PCIe PHY support for Cygnus Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432284459.27695.41.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=arunp@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jdzheng@broadcom.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox